Comments (8)
This is now released in 2.25.2
from webpack-hot-middleware.
Yeah, I should have some time tomorrow to take a look and get this sorted
Thanks for the prompt
from webpack-hot-middleware.
The deprecation warning on that npm
package is actively harmful imo.
The querystring API is considered Legacy. While it is still maintained, new code should use the API instead.
There is nothing about this message that suggests there is any real reason to stop using the existing API which has been stable for years.
That said, there iss an open PR for this already #411
from webpack-hot-middleware.
Agreed @glenjamin, but deprecated dependencies typically stop getting support and using standard APIs for such a minor usecase would offer better long term support.
Thanks for pointing out the open PR - missed that one and was about to open another.
from webpack-hot-middleware.
using standard APIs for such a minor usecase would offer better long term support.
Yeah, if this was a random 3rd party module I'd be more inclined to switch, but querystring
has been a standard and stable part of Node.js since at least 0.10.x in 2013, if not longer!
I suspect that npm warning is annoying enough that it's going to be easier to merge the PR than to leave things as they are
from webpack-hot-middleware.
@glenjamin hey! friendly ping:
That said, there iss an open PR for this already #411
it's going to be easier to merge the PR than to leave things as they are
are there any plans or barriers to merge that PR?
from webpack-hot-middleware.
The only barrier right now is that I never got around to it, and I really really really dislike that they've marked a core library as actively deprecated rather than just frozen.
There is literally nothing wrong with the current code - and it annoys me that someone has created this work for any maintainer that depends on querystring.
from webpack-hot-middleware.
@glenjamin yeah, it's disappointing. I understand.
Contrariwise I think I can understand the author of that package. querystring
is based on the corresponding module from Node.js. And he, in turn, is legacy
now (https://nodejs.org/api/querystring.html). Thus, the package continues to keep parity with its original. Or maybe I just made it up myself.
Anyway, on the other hand, we are users of these packages who receive annoying warning that distract from the really important warnings.
from webpack-hot-middleware.
Related Issues (20)
- TypeError: cb is not a function HOT 1
- error TS2339: Property 'compilers' does not exist on type 'Compiler'. HOT 1
- Which package to use on a Deno server? HOT 1
- `webpack-hot-middleware/client?reload=true` is no longer working with webpack 5. HOT 36
- not work on webpack5 HOT 7
- Overlay is not working with Webpack 5 HOT 4
- Ignored an update to unaccepted module - No automatic page reloading with recent versions of webpack and react packages HOT 3
- Types are broken with Webpack 5 HOT 3
- `module.hot` is required ?
- enable use of other backends besides express
- when updating the example everything will break please update HOT 4
- ReDoS Vulnerability HOT 2
- Overlay is invalid in webpack5. Haven't you solved it yet? How long do you plan to publish it to the master? I hope you can reply
- Hot Updates not being handled by server HOT 2
- Opening 5+ tabs causes Express to hang indefinitely HOT 2
- webpack-hot-server-middleware on demand loading bug
- webpackv5 webpack-hot-server-middleware Compatibility problems HOT 1
- A Chrome specific issue, where requests are getting blocked after a handful of link clicks HOT 3
- Webpack 5: incorrect compilation error text output starting with "undefined undefined" HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webpack-hot-middleware.