GithubHelp home page GithubHelp logo

Comments (13)

relacsua avatar relacsua commented on April 28, 2024

@gaearon You can enable ES6 support with jsx-loader by appending ?harmony and you can see that in the config file.

from react-starter.

gaearon avatar gaearon commented on April 28, 2024

I can, but it supports a lot less ES6 than Babel. See http://kangax.github.io/compat-table/es6/

from react-starter.

FoxxMD avatar FoxxMD commented on April 28, 2024

👍

from react-starter.

sokra avatar sokra commented on April 28, 2024

👍

from react-starter.

Rockfordal avatar Rockfordal commented on April 28, 2024

babel works great for me, i excluded node_modules.
(im using reflux, material-ui, socket.io). tnx for a superb starter!

from react-starter.

FoxxMD avatar FoxxMD commented on April 28, 2024

@Rockfordal how did you switch? I've added babel to additional loaders in webpack and concatenated these to the final loaders but it doesn't seem to be working.

I get a module parsing failure on app.jsx in config :/

from react-starter.

sokra avatar sokra commented on April 28, 2024

You need to change these lines:

Someone like to do a PR?

from react-starter.

sokra avatar sokra commented on April 28, 2024

As next step we can change the module style to ES6 modules.

from react-starter.

FoxxMD avatar FoxxMD commented on April 28, 2024

@sokra Doesn't using loadersByExtension preclude the possibility of writing your own tests and excludes for any loaders? If I wanted to write my files as normal .js and use babel-loader I wouldn't be able to exclude node_modules, or am I overlooking some functionality in loadersByExtension that allows this?

Also, If I am using additionalLoaders and concat them why would they not be be working? I have commented out the extension loader for jsx and my additionalLoaders look like this:

    var additionalLoaders = [
        { test: /\.js$/, exclude: /node_modules/, loader: "babel-loader" }//,
        { test: /\.jsx$/, exclude: /node_modules/, loader: options.hotComponents ? ["react-hot-loader", "babel-loader"] : "babel-loader" }
    ];

from react-starter.

sokra avatar sokra commented on April 28, 2024

Should also work.
But you can specify exluce and include in loadersByExtension. See https://github.com/webpack/react-starter/blob/master/make-webpack-config.js#L16-L19

from react-starter.

FoxxMD avatar FoxxMD commented on April 28, 2024

That worked! So what is loadersByExtension doing that concatenating additionalLoaders is not?

Also I'll make a PR tomorrow

from react-starter.

pikeas avatar pikeas commented on April 28, 2024

@FoxxMD #42

from react-starter.

sokra avatar sokra commented on April 28, 2024

#60

from react-starter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.