GithubHelp home page GithubHelp logo

Comments (4)

webpro avatar webpro commented on September 28, 2024

Yeah, this should be documented better.

The problem here is that Knip does not know what is an npm package and what is an OS binary. While for echo and exit this may sound obvious, it's hard to draw a line here. Currently only these binaries are ignored: https://github.com/webpro/knip/blob/main/src/constants.ts#L20

Perhaps I should just add exit and echo to the list, since these packages are 9 and 12 years old, respectively.

For now you could add ignoreBinaries: ["echo", "exit"] to the Knip config.

from knip.

ElPrudi avatar ElPrudi commented on September 28, 2024

I think it would be useful to add the most commonly used Linux, CMD and PowerShell commands as I think these are very commonly included in scripts across plattforms. And to point out on the README if they are OS commands.
Links:
https://kinsta.com/blog/linux-commands/
https://www.digitalcitizen.life/best-cmd-commands/
https://www.educba.com/powershell-commands/

It's not the end of the world, but it's important to have heard of it.

from knip.

webpro avatar webpro commented on September 28, 2024

Thanks for your input! I've added a few binaries to the ignore list (1.7.0) and a small section in the readme.

from knip.

ElPrudi avatar ElPrudi commented on September 28, 2024

I am going to close this, as it now covers these os commands.
Thank you for your blazingly fast response and keep up the good work!

from knip.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.