GithubHelp home page GithubHelp logo

Comments (6)

program247365 avatar program247365 commented on September 1, 2024

👍

from ie8.

WebReflection avatar WebReflection commented on September 1, 2024

I don't understand where is the error, I have green light in here down to the last test which is

      var xhr = new XMLHttpRequest,
          OK = wru.async(function () {
            wru.assert('OK');
          });
      xhr.open('get', '?' + Math.random(), true);
      xhr.addEventListener('readystatechange', function () {
        if (this.readyState == 4) {
          OK();
        }
      });
      xhr.send(null);

Can you please provide a code that fails ?

I also give for granted you are trying with a real IE8 and not an emulator but if this is not the case there you have a problem.

Thanks for any extra detail on this.

from ie8.

WebReflection avatar WebReflection commented on September 1, 2024

the test: http://webreflection.github.io/ie8/test/

from ie8.

WebReflection avatar WebReflection commented on September 1, 2024

also, your change makes everything enumerable which I believe is undesired but that being said, I wonder if you are including anything before the ie8 file so that your XMLHttpRequest is not the original/real one but a fake/shimmed polyfill that should not be patched … this would explain the problem but it's not really in ie8.js, rather ion the order you include scripts in your page.

I don't think ie8 should patch objects it does not own/understand so I'd rather go for a try catch but I actually suggest you to put ie8 on top of everything

from ie8.

WebReflection avatar WebReflection commented on September 1, 2024

hey @standup75 can you please let me know if you solved the problem?

from ie8.

standuprey avatar standuprey commented on September 1, 2024

This is part of a big app, and I am off this week, but will get back to you next week with a simple example

from ie8.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.