GithubHelp home page GithubHelp logo

Comments (6)

rainliu avatar rainliu commented on May 26, 2024 1

Thanks for the sharing.

I will make a new release soon.

from webrtc.

rainliu avatar rainliu commented on May 26, 2024 1

webrtc v0.10.0 is released.

from webrtc.

LIMPIX31 avatar LIMPIX31 commented on May 26, 2024

Okay. In the second case I forgot to close the connections, but in the first case there's still something wrong.

peer_connection.close().await hangs

  peer_connection.on_peer_connection_state_change({
    let peer_connection = peer_connection.clone();

    Box::new(move |s| {
      info!("Peer Connection State has changed: {s}");
      let peer_connection = peer_connection.clone();
      Box::pin(async move {
        use RTCPeerConnectionState::*;

        if let Disconnected | Failed = s {
          info!("Attempting to close ended connection");
          if let Err(err) = peer_connection.close().await {
            error!(%err);
          } else {
            info!("Connection closed");
          }
        }
      })
    })
  });

from webrtc.

samguns avatar samguns commented on May 26, 2024

Interestingly, we have an app seemingly the same as you've done. It employs HTTP served by Axum to do the signaling. Everything works fine but a similar scenario especially the high CPU usage was observed in our app as well, even if we made sure the peer connection had been closed explicitly. Did you get any progress further concerning this issue? @LIMPIX31

from webrtc.

LIMPIX31 avatar LIMPIX31 commented on May 26, 2024

Interestingly, we have an app seemingly the same as you've done. It employs HTTP served by Axum to do the signaling. Everything works fine but a similar scenario especially the high CPU usage was observed in our app as well, even if we made sure the peer connection had been closed explicitly. Did you get any progress further concerning this issue? @LIMPIX31

Thanks for your reply. Unfortunately I was not able to find out more. I was in a hurry, so I had to write a broadcast server in golang as a temporary solution.

from webrtc.

samguns avatar samguns commented on May 26, 2024

Some follow-ups to share with you @LIMPIX31 and to all users especially devs of this project.
After browsering through PRs and we found this recently merged #514 seemed highly related to what we experienced. So we changed crate source to pull latest code from master branch instead of v0.8.0 in crate.io. The issue disappeared. Maybe you could try it as well and let's wait for a formal new release in crate.io.

from webrtc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.