dht.get() error, BEP 44 broken about bittorrent-dht

[resession]

this error is stemming from updates that has been made to https://github.com/webtorrent/node-bencode

[ThaUnknown]

this is an issue caused by ed25519-supercop not DHT?...

[resession]

this is an issue caused by ed25519-supercop not DHT?...

yes but it is because ed25519-supercop expects either a string or buffer, but bittorrent-dht/bencode.encode() is returning a Uint8Array

https://github.com/webtorrent/bittorrent-dht/blob/master/client.js#L781C22-L781C22

check index.js, line 28
https://www.npmjs.com/package/ed25519-supercop?activeTab=code

  else if (!Buffer.isBuffer(message)) {
    throw new Error('message must be a buffer or a string')
  }

its throwing the error because bittorrent-dht/bencode is returning a Uint8Array, Buffer.from(Uint8Array) fixes it

[ThaUnknown]

once again, this should be fixed on ed25519-supercop's end, not bittorrent-dht's end, or you can simply wrap ed25519 using buffer.from like you said

uint8array is a perfectly valid way of storing uint8 data, and unlike buffer it's cross env compatible, and as we plan on implementing DHT in web one day, Buffer would end up being removed anyways