Comments (6)
@Spreeuw this was part of your contribution in 4582a2b. Can you remember why you added this check?
from edd-helpscout.
@webzunft looking at the blame
view of the original code in the PR it seems to be an unintended inclusion of this line in the if-statement:
edd-helpscout/views/licenses.php
Line 21 in c3692c8
I do remember we experimented with placing the gear icon after the license key but that didn't work out very well in the space HelpScout offered when there was also a license tier to be printed, and I think (but I can only guess since it's been so long) that this resulted in this configuration with the license tier and gear icon on one line and the key on the next.
That said, I guess that since for bundled licenses the gear icon is already printed after the license key too (source), it makes sense to do the same for non-bundled items, basically moving that gear line 3 lines down.
Just to double check: @Terminator-Barbapapa did you have any specific reason to put the gear after the tier (price_option
) instead of the license key?
from edd-helpscout.
If I remember correctly we've placed the gear icon there because there was too little room next to the license key.
from edd-helpscout.
If I remember correctly we've placed the gear icon there because there was too little room next to the license key.
but there's even less room for it on the bundled items 😬 (where it is currently printed next to the license key already).
Perhaps it was a sequential change: at first everything was in one line (with the gear at the end) but that didn't fit nicely and then we move the last part (tier + gear) as a whole rather than reconsidering the position of the gear.
from edd-helpscout.
I definitely remember there was a room issue. 🙂
Could indeed be that everything in one line got too crowded and we moved the tier and gear.
from edd-helpscout.
Thanks to everyone involved!
from edd-helpscout.
Related Issues (20)
- Deactivate license link in HS sends to blank page, doesn't deactivate license HOT 10
- Remove 2nd filter parameter in edd_helpscout_before_order_downloads & after filter.
- PayPal Express payment link in HelpScout not working HOT 7
- Lookup license key info using license key value in Help Scout form HOT 1
- Check for secondary email addresses HOT 4
- Notes on multiple accounts HOT 2
- Show multiple accounts HOT 3
- Flexible date format
- Support for EDD Quaderno's invoice link HOT 1
- Support HelpScouts new Mailbox 2.0 API HOT 3
- Add notes HOT 1
- Lifetime license info HOT 1
- Subscription status HOT 2
- Update query_customer_payments() for EDD 3.0 compatibility HOT 1
- /edd-helpscout-api/customer_info HOT 9
- Link to API Endpoint plugin
- Handle empty emails from HS API
- persist open/closed status of toggle sections HOT 6
- Bring back Resend Receipt Link HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from edd-helpscout.