License management link missing on some licenses? about edd-helpscout

[webzunft]

@Spreeuw this was part of your contribution in 4582a2b. Can you remember why you added this check?

[Spreeuw]

@webzunft looking at the blame view of the original code in the PR it seems to be an unintended inclusion of this line in the if-statement:

edd-helpscout/views/licenses.php

Line 21 in c3692c8

<a href="<?= $license['url']?>" target="_blank"><span class="icon-gear" style="font-size: 16px; margin-left: 4px;"></span></a>

I do remember we experimented with placing the gear icon after the license key but that didn't work out very well in the space HelpScout offered when there was also a license tier to be printed, and I think (but I can only guess since it's been so long) that this resulted in this configuration with the license tier and gear icon on one line and the key on the next.

That said, I guess that since for bundled licenses the gear icon is already printed after the license key too (source), it makes sense to do the same for non-bundled items, basically moving that gear line 3 lines down.

Just to double check: @Terminator-Barbapapa did you have any specific reason to put the gear after the tier (price_option) instead of the license key?

[Terminator-Barbapapa]

If I remember correctly we've placed the gear icon there because there was too little room next to the license key.

[Spreeuw]

If I remember correctly we've placed the gear icon there because there was too little room next to the license key.

but there's even less room for it on the bundled items 😬 (where it is currently printed next to the license key already).

Perhaps it was a sequential change: at first everything was in one line (with the gear at the end) but that didn't fit nicely and then we move the last part (tier + gear) as a whole rather than reconsidering the position of the gear.

[Terminator-Barbapapa]

I definitely remember there was a room issue. 🙂
Could indeed be that everything in one line got too crowded and we moved the tier and gear.

[webzunft]

Thanks to everyone involved!