Please don't make me do stupid dances (aka results dir is created before SELinux status is checked) about lorax

[bcl]

Better yet is to collect the possible errors and display them all at once instead of failing immediately. See livemedia-creator for example.

[vpodzime]

Same here. :)

[AdamWill]

Yay! But don't we now have the same check twice?

lorax/src/pylorax/__init__.py

Lines 226 to 240 in dc635a9

	# is selinux disabled?
	# With selinux in enforcing mode the rpcbind package required for
	# dracut nfs module, which is in turn required by anaconda module,
	# will not get installed, because it's preinstall scriptlet fails,
	# resulting in an incomplete initial ramdisk image.
	# The reason is that the scriptlet runs tools from the shadow-utils
	# package in chroot, particularly groupadd and useradd to add the
	# required rpc group and rpc user. This operation fails, because
	# the selinux context on files in the chroot, that the shadow-utils
	# tools need to access (/etc/group, /etc/passwd, /etc/shadow etc.),
	# is wrong and selinux therefore disallows access to these files.
	logger.info("checking the selinux mode")
	if selinux.is_selinux_enabled() and selinux.security_getenforce():
	logger.critical("selinux must be disabled or in Permissive mode")
	sys.exit(1)

I guess that should stay for things using pylorax but not lorax CLI...if there are any?

[bcl]

Yes, that's there to catch any library users.