Argument Text Object: Handle quotes about targets.vim

[wellle]

Both problems are working as expected. There is currently no support for handling strings in arguments. To targets.vim it looks like this:

line       | function(a, 33, Rstyle="calls, with commas inside strings, are OK")
separators |         ( ,   ,              ,                           ,        )
arguments  |          1 222 33333333333333 444444444444444444444444444 55555555

I implemented support for nested blocks and such because it is straight forward to match them. When I see an opening ( I know that I should look for the closing one on the right. Implementing the same for quotes is more complicated because I don't know where a quote starts and ends. In our example there are two possible interpretations (depending on context):

line       | function(a, 33, Rstyle="calls, with commas inside strings, are OK")
quotes     |                        "                                         "
contents A |                         22222222222222222222222222222222222222222
contents B | 11111111111111111111111                                           3

It might seem natural that A is the better fit in this case, but how would you express that?

One approach I've chose for quote text objects could be applied here as well: If there's an even number of quote characters on the line, assume that the first one begins a quote. That would work in this example. But how do we deal with cases where there's an odd number of quotes in the line?

I'd like to avoid being dependent on filetype specifics. If you can help me come up with a solid set of rules I might consider implementing something like this. Otherwise I'd rather keep it simple by not supporting it at all.

By the way, I see that this is an example line. Did you open this issue because you were curious if it works, or do you actually have real world use cases where this would be needed? Because, again, I'd rather keep it simple until features are actually needed.

Oh and lastly, I just tried to reproduce your final result with the cursor in the first column. I tried with your exact Vim version 7.4.273, but it always worked as expected: When trying to select an invalid target I hear a beep while the last visual selection remains unaffected. What version of targets.vim are you using?

[orbisvicis]

I tried with your exact Vim version 7.4.273, but it always worked as expected

Fixed by your 567a293 commit.

By the way, I see that this is an example line. Did you open this issue because you were curious if it works, or do you actually have real world use cases where this would be needed?

It does occur now and then: Logger(WARN, "Error: received X, expected Y")

But how do we deal with cases where there's an odd number of quotes in the line?

First, is there a real-world case of arguments with an odd number of quotes where the odd-quote-out isn't preceded by a backslash?

[wellle]

I see, I will consider handling quotes for argument text objects 👍

[unphased]

The way to deal with this is should probably be to leverage syntax highlighting state as a hint... Also the (pretty old) argtextobj vim plugin handles this case correctly, but where it falls down (and targets.vim is better at) is with argument lists that span multiple lines.

So maybe you can ape what argtextobj did to detect quotes.