Indenting inside curly braces includes last brace line about targets.vim

[wellle]

Thank you for letting me know! I can reproduce the issue and agree that it should be fixed. I will address this in the next days.

[UnrealQuester]

Use IB instead of iB. I is exluding whitespace whereas i is everything inside the braces. If you do not like this behaviour you can change g:targets_aiAI and switch I and i.

[dhleong]

Should the brace be considered "inside" the brace, though? That doesn't
seem logical, not to mention breaking expected behavior with default vim.

[UnrealQuester]

The brace is not selected when executing >iB, but the whitespace before it in the same line is. You can canfirm this with viB. ">" does not care what is actually selected by the text object. It only operates on lines. Because the last line with the brace has the whitespace selected it is indented as well. However, I agree that the default behaviour of I and i should be switched. But this would break backwards compatibility.

[dhleong]

Ah, I see. Thank you for explaining.

[wellle]

@UnrealQuester Thank you for the explanation. I was actually thinking about switching i and I for a while now. Most of the time excluding the whitespace seems to be more natural. However, both versions have their use case:

• when changing, whitespace should be preserved cI}
• when deleting, whitespace should be removed di}

I am not sure what is the more common operation. One could even think about combining i} to work differently depending on the pending operator. But that sounds complicated and is not easy to expand when working with third party operators like vim-surround or vim-exchange.

If you want to continue this discussion, feel free to open a separate issue. 👍

[wellle]

@dhleong The issue is fixed with #70. Multiline selections where the last line consists only of whitespace will exclude that whitespace now. This should be compatible with default Vim.

Thanks again!

[dhleong]

Awesome, thank you!