GithubHelp home page GithubHelp logo

Comments (4)

sobolevn avatar sobolevn commented on May 20, 2024

if a > 6 or a <= 4: :)

from wemake-python-styleguide.

Xoriun avatar Xoriun commented on May 20, 2024

Yes, but that's not a chain condition, which is the whole point of this report.

from wemake-python-styleguide.

sobolevn avatar sobolevn commented on May 20, 2024

Forbid not with compare expressions.

This is exactly what this rule does. Or am I missing something? :)

from wemake-python-styleguide.

Xoriun avatar Xoriun commented on May 20, 2024

This rule forbids something like if not a < b since it can be rewritten as if a >= b. Here, the second version is clearly more readable which is (as I understand it) the reason for the rule - readability.
But for chain comparisons like if not a < b < c there is no way to rewrite it without not but still maintaining the chain comparison. Removing not leads to something like if a >=b or b >= c which (at least for me) is quite a lot less readable than what I had before. I would be fine with negated chain comparisons needing parentacise around them like if not (a < b < c).

from wemake-python-styleguide.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.