Comments (9)
Thanks.I just fixed it in version 0.5.2. Try it out.
from fscalendar.
Excellent! Thank you for fixing this so quickly. Should I mark this closed? Or is that something you do? I’ve never added an “issue” on git before.
Thanks,
Bob.
PS. Really like the calendar you put together. I’m testing it out now - but it’s looking like I’ll be using it in my app.
Bob Glass
Workbox Software LLC
workboxsoftware.com
On Mar 27, 2015, at 9:59 PM, Wenchao Ding [email protected] wrote:
I just fixed it in version 0.5.2. Try it out.
—
Reply to this email directly or view it on GitHub #18 (comment).
from fscalendar.
Would be great if you use it in your app! The issue could be left open for some days to others who wanna use it. I'll close it later~ Thanks for pointing it out. And if you still have other issue for this lib, feel free to post it here~
from fscalendar.
Hi Wenchao -
I have another request. This is not a bug - just a cosmetic issue. About 1/2 the dates on my calendars will typically have a subtitle. When that happens, the date and subtitle get centered vertically which pushes the date up. It creates a zig-zag effect with the dates no longer aligned. I can add a blank subtitle which fixes the zig-zag issue, but then the date is no longer centered when a date is selected and the blue background is shown. This is not a “stopper” - just a nice to have fix.
Thanks,
Bob.
Bob Glass
Workbox Software LLC
workboxsoftware.com
On Mar 28, 2015, at 12:26 AM, Wenchao Ding [email protected] wrote:
Would be great if you use it in your app! The issue could be left open for some days to others who wanna use it. I'll close it later~ Thanks for pointing it out. And if you still have others issues for this, feel free to post it here~
—
Reply to this email directly or view it on GitHub #18 (comment).
from fscalendar.
Hey, Bob:
I really haven't thought about this zig-zag problem. But if you want the day cell align neatly, the date text centainly wouldn't center. So you need to only center the selected cell?
from fscalendar.
Hi Wenchao -
I can see that there’s no great solution to this. Maybe if I could center the highlighted days it would look better - not sure though - I’d have to see. It’s not that bad - most people wouldn’t notice the zig-zag.
I have another request. I’d like to select the 1st of the month whenever a user switches months - similar to the way the iPhone Calendar works. But the following didn’t work - the screen just hung. Any suggestions?
- (void)calendarCurrentMonthDidChange:(FSCalendar *)calendar
{
NSLog(@"did change to month %@",[calendar.currentMonth fs_stringWithFormat:@"MMMM yyyy"]);
NSDate *date = [[calendar currentMonth] beginningOfMonth];
_fsCalendar.selectedDate = date;
}
Bob Glass
Workbox Software LLC
workboxsoftware.com
On Mar 31, 2015, at 1:38 AM, Wenchao Ding [email protected] wrote:
Hey, Bob:
I really haven't thought about this zig-zag problem. But if you want the day cell align neatly, the date text centainly wouldn't center. So you need to only center the selected cell?
—
Reply to this email directly or view it on GitHub #18 (comment).
from fscalendar.
I see. You can try to add a conditional checking in setSelectedDate
around [self scrollToDate:_currentMonth]
if (!_collectionView.tracking && !_collectionView.decelerating) {
[self scrollToDate:_currentMonth];
}
I think it would work.
from fscalendar.
Hi Wenchao -
I think I found a couple of bugs. Here’s how to reproduce the first one.
Run the Example.
Switch to Vertical
Scroll backwards to January.
Go to Settings and select April 1st.
To the left of April 1st is March 31st. If you tap that date you go to May instead of March.
The other bug is that the routine doesn’t always scroll the selected date. Here’s how to reproduce:
Run the example
Switch to Vertical
Scroll to May
Select April 1st from settings screen. (this will work)
Scroll to May
Select April 1st from settings screen (this will not scroll back to April).
Let me know what you think -
Thanks,
Bob.
Bob Glass
Workbox Software LLC
workboxsoftware.com
On Mar 31, 2015, at 9:47 PM, Wenchao Ding [email protected] wrote:
I see. You can try to add a conditional checking in setSelectedDate around [self scrollToDate:_currentMonth]
if (!_collectionView.tracking && !_collectionView.decelerating) {
[self scrollToDate:_currentMonth];
}
I think it would work.
—
Reply to this email directly or view it on GitHub #18 (comment).
from fscalendar.
- The first one can not be reproduced now. Maybe because I just fixed another issue and deliberately fix that one too~
- The reason for the second one is that the
selectedDate
is already the date you wanna select. So it did't perform a selection action. So your idea is thatselectedDate
should always be scrolled to even it is already aselectedDate
?
As this is already a long page and the original idea of 'issue', I think it would be better to open a new issue if the future problem is not directively relative to this topic:)
from fscalendar.
Related Issues (20)
- Add week numbers to month view
- How to add an image above the date?
- Thread 1: "-[_NSCopyOnWriteCalendarWrapper fs_firstDayOfMonth:]: unrecognized selector sent to instance 0x281cd4200"
- Question about a custom design
- Title is added on unelected date on scroll month . HOT 1
- how make select two dates only one to start date and anther to end date ?
- FSCalendar not working in updated Xcode (14.3) HOT 2
- Terminating app due to uncaught exception 'CALayerInvalidGeometry', reason: 'CALayer position contains NaN: [nan 447]. Layer: <CALayer:0x600000444080; position = CGPoint (0 0); bounds = CGRect (0 0; 258.5 48); delegate = <_UIEditMenuListView: 0x7ff095714380; frame = (-129.25 -24; 258.5 48); alpha = 0; layer = <CALayer: 0x600000444080>>; sublayers = (<CALayer: 0x600000444240>); opaque = YES; opacity = 0; shadowOpacity = 0.25; shadowOffset = CGSize (0 3); shadowRadius = 12>'
- Auto Rotation layout issues HOT 6
- 设置为周模式时候,为什么日期的高度很小,设置成200-300正常
- date getting overlap each other, while scorlling horizontally
- Fix date range multiselect HOT 1
- 视觉障碍人士开启辅助功能的旁白(voice over),日历的滑动切换功能就失效了
- Voice Over Enabled - Prevent announcing previous and next month names HOT 1
- iOS 17 doesn't renders the months correctly HOT 5
- Header background color issue
- How to add contentInset to scrollview / collectionview / calendar?
- Privacy Manifests HOT 12
- Unable to run the app - Command phase script execution failed due to non zero exist code.
- Attempted to modify the selection of an item in an out-of-bounds section (647) when there are only 647 sections. HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fscalendar.