Signature Images v3.1 about wet-boew-php

[LaurentGoderre]

@pjackson28 isn't this image replaced by javascript?

[upsonp]

It wasn't when I set wet-boew v3.1 up on my dev system. I was doing this to get the geomap extension working so I wanted to start from a clean slate. I deleted all the pre-existing files and started with a clean slate. I copied the wet-boew/dist files over then the wet-boew-php/demos-php files over. Then fixed the paths, everything worked except the images. An issue could have happened when I corrected the paths. I'll re-try and let you know how it goes.

[pjackson28]

The issue is that the release schedules for variants are a bit behind WET core. The PHP and SSI variants need to be updated to the v3.1 markup. The project lead @jeffdavidgordon is unable to do this at this time so the PHP and SSI variant updates will need to be done by someone else.

@upsonp Would you be willing to update the PHP markup to v3.1 on the behalf of @jeffdavidgordon to help speed up the release?

[upsonp]

I'll make the change to the /theme-wet-boew/inc/cont/header-entete.php where I know the issue exists. I'm unaware if there are issues any place else, but will make updates if I find them.

Are we giong to do anything about the black text on the GoC signature? maybe make the text white?
I used GIMP to invert the text color this is the result, but come to think of it I think the flag and text use to be white.

[pjackson28]

The FIP images issue will be fixed when the markup is updated as the old markup doesn't trigger the image switching JavaScript (used to support both print and screen media types).

As for markup changes, you can find out what has changed in the v3.1.0 release notes: https://github.com/wet-boew/wet-boew/wiki/v3.1.0-release-notes

There are diffs included in there to show relevant changes.

[upsonp]

I made the update. I think I fudged something up and committed directly to the master instead of updating the branch and submitting a pull request.

[pjackson28]

I'm looking at the commit history on GitHub and don't see any changes so it likely just happened with your local copy or in your fork. Try a new pull request and see if it includes all your changes.

[pjackson28]

@upsonp I've updated most of the markup to WET v3.1.0. Please check to make sure nothing was missed. Please also compare the rendered result to the regular HTML versions to ensure they align.

[upsonp]

@pjackson28 I'm running into a couple of issues. I'm going to need some more time to analyze the code, but here's what I'm having trouble with.

1. The sig-eng.svg and wmms.svg images aren't showing up at all, They won't even fall back to the PNG images when I delete the SVG images from my dev server, I even removed the SVG mime-type from the server. I've checked the image paths and they're correct

2. My mega menu and breadcrumb trail have also disappeared. I'm thinking this issue is somewhere between line 16 and 25 of the header-entete.php file. It might have to do with the $_PAGE['nositemenu'] == '' in the if statements. When I do a print_r on the $_PAGE array 'nositemenu' and 'bcrumb_hide' aren't in the list, I'm going to try setting them explicitly to see if I can change the outcome, but this shouldn't be affecting the images.

As a side note, is there some reason we're not using the $_UNKNOWN['gc_theme_folder'] and $_UNKNOWN['gc_build_folder'] variables set in the /theme-gcwu-fegc/inc/config.php file instead of the actual paths?
I.E.
Instead of

$_SERVER['DOCUMENT_ROOT'] . "/wet-boew/build/inc/body-corps-1a.php";

Use

$_SERVER['DOCUMENT_ROOT'] . $_UNKNOWN['gc_build_folder'] ."/inc/body-corps-1a.php";

Using the $_UNKNOWN['gc_theme_folder'] and $_UNKNOWN['gc_build_folder'] variables would mean I wouldn't have to do a mass replace on paths every time I updated my site with the wet-boew-php package and risk screwing up the paths. I'd just have to paste in my sites custom config.php file, which I have to do anyway for the sites title, language swap feature, urls, etc...

[pjackson28]

@upsonp It's important to note that there are likely bugs in my changes as I don't have the tools to test the code (including the php if statements which likely are part of the problem). Many of the issues that you've found could be from coding issues. Please do a comparison with the HTML templates to make sure it is outputing the HTML markup correctly.

1. The SVG images will only display on SVG-capable browsers (so not IE7/8). For non-capable browsers the object element is stripped away to allow the PNG to display (since some non-capable browsers don't handle object fallbacks properly). If you are using a non-capable browser then likely bugs in the rendered HTML markup are interfering with WET's ability to free up the fallback.

2. That is probably from bugs in the php if usage. It should only hide this menu for PHP files with nositemenubc in the name.

As for your question about gc_theme_folder and gc_build_folder, I'm not very familiar with this variant so don't know the answer. Important to note though that we no longer use the "build" folder and instead use the "dist" folder. You are welcome to make improvements to the code. Also note that the intention is to add support for the other themes (WET v3.1 supports 4 excluding the CLF2 theme) so mechanisms should be generic where possible.

[upsonp]

@pjackson28 Thank and sorry, I should have said I did compare the HTML with the PHP using a view source on one of my php pages vs. one of the working demo html pages, SVG graphics work in the standard HTML demo pages. There was no discernible difference in the section of code containing the svg graphics, it's probably a typeo (i.e. two letters swapped) that I just haven't seen yet.

I also meant to state that I'm testing in Chrome and Firefox. I'm going to edit a big section of code and add some comments in hopes it'll make it more readable. When I'm coding in PHP I don't generally jump back and forth between the HTML and PHP it makes it really hard to read, but that's just me. I'll make a pull request when I have it's working on my dev server and will make adjustments if asked to.

I'll leave the paths as they are for now, I'll have to research WET v4 to determine if using the variables in the config.php file is an acceptable approach.

[upsonp]

@pjackson28 Got it working, the issue was actually spread out over several files. There were a bunch of 'theme-wet-boew' used in several paths that should have been theme-gcwu-boew'.

I'll make a pull request to fix the paths and the /theme-wet-boew/inc/cont/header-entete.php. It might take me awhile.

[upsonp]

@pjackson28 @jeffdavidgordon I did another clean install of the WET 3.1 and PHP variant files on my dev site. It went pretty smoothly this time and seems to be working fine. I think it's safe to close this issue.

I'll make updates to the PHP variant as time permits.

[pjackson28]

Thanks! Do you have any interest in replicating this for the GCWU intranet, WET and Base themes as well? Would be great to add support for those themes as well if you have the time.

[upsonp]

@pjackson28 Sure, as time permits. I have quite a few pages to bring up to speed for my site, but used properly the PHP variant saves a ton of time in development. It's a huge asset, I also plan on updating some of the documentation and demos.

I have some changes to the php file structure to make it easier to integrate with the core WET 3.1 files I'd like to discuss, is there an "enhancement" section for github or do I just open a new issue?

[pjackson28]

@upsonp That's great! Would you like me to grant you sub-project lead permission to the wet-boew-php repository? It gives you push access to the repository so should make it easier to accomplish things. A side benefit is that it lets you set labels and milestones for issues, where one of the labels could be enhancement.

As for where to have the discussion, best to start a new issue and discuss there. An "enhancement" label could be applied to the thread to help identify it as an enhancement discussion.

[upsonp]

@pjackson28 That sounds great. My one concern is I like having code reviews done before merges are done, I don't always pickup on the small things like the /demos-php and /build path issues. It's nice to have the second pair of eyes, so I prefer having someone else merge my changes in.

[pjackson28]

@upsonp You can still have code reviews even if I give you push access. That happens fairly frequently over at wet-boew. I'll add you as a sub-project lead so you can at least start using labels and such.