GithubHelp home page GithubHelp logo

Comments (9)

nschonni avatar nschonni commented on August 20, 2024

I'm wondering if the dist directory should be a configuration variable. This would support using a git submodule to wet-boew-dist directory for the demos vs the correct directory in a real deploy.

from wet-boew-php.

pjackson28 avatar pjackson28 commented on August 20, 2024

@upsonp You are welcome to reconfigure the directory structure as needed but note that people like @DavidMacDonald have been using this variant in the past so you should be careful with the changes you make.

from wet-boew-php.

pjackson28 avatar pjackson28 commented on August 20, 2024

@upsonp By the way, I made a few changes last night to better split up the generic and theme-specific to make it easier when you start to add support for the other themes.

from wet-boew-php.

upsonp avatar upsonp commented on August 20, 2024

Directory structure has been fixed in the PHP Variant. The $_SITE['xxx_folder'] variables from the /dist-php/config/{theme}/config.php file are used throughout the variant. Change the path in the main config file for a site changes it for the rest of the site, making deployment easier.

from wet-boew-php.

nschonni avatar nschonni commented on August 20, 2024

I still think the wet files need to be an independent variable. I've setup the submodule on this branch https://github.com/nschonni/wet-boew-php/tree/azure-demos but a submodule can't point to a folder below the other repos root.

from wet-boew-php.

LaurentGoderre avatar LaurentGoderre commented on August 20, 2024

I agree. There's also the use case of when the WET files are hosted on a different server. (ex. WET files resides on the static web site and web applications on a different server reference the files on the static site server)

from wet-boew-php.

nschonni avatar nschonni commented on August 20, 2024

👍 on all the hard work @upsonp
I'm not a PHP guy so maybe what I'm asking isn't practical. I'd just like to solve this for #20 so we can have the CI releases of all your work!

from wet-boew-php.

upsonp avatar upsonp commented on August 20, 2024

@LaurentGoderre @nschonni I might be misunderstanding, but I did make the core WET distribution folder separate from the php variant distribution.

The way I have it setup for the demos is the core WET /dist folder and the PHP variant /dist-php folder are in the same root directory, but they don't have to be. I tried to make it so the user wouldn't have to change anything in the /dist-php/ directory. Variables can all be overriden in a custom config file that will call the /dist-php config files mainly because when I update the BIO website I just want to dump the new variant files in there and not have to modify all the config stuff every time.

I don't know if this would work if PHP applications were being run on one server, referencing core WET files on a separate server. Interesting thought though and would make a pretty neat experiment. If you want the core wet files and the php variant files to be in different places:

At the top of the /demos-php/config/theme-gcwu-fegc/config.php file set $_ROOT_SERVER_DIR = "";. Now add the $DEPLOY_FOLDER_DIST and $DEPLOY_FOLDER_PHP variables and use them instead to point to different places:
e.g.
$DEPLOY_FOLDER_PHP = "/wet-boew-php/"
$DEPLOY_FOLDER_DIST = "/wet-boew-dist/"

These variables reside in the /dist-php/config/config.php file and are used to set the $_SITE['wb_core_dist_folder'] and $_SITE['wb_php_dist_folder] variables.

Of course I should have, but didn't document that.

I'm especially interested in resolving #20 as well. The password protected site where I currently have the demos isn't intended to be a permanent location. That server is a legacy DFO server and intended to be retired. No date has been nailed down, but it was suppose to already have happened.

from wet-boew-php.

nschonni avatar nschonni commented on August 20, 2024

OK, I'm going to move the discussion back to #20 and maybe you can figure out what I've done wrong 😄

from wet-boew-php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.