Government of Canada FIP signature at the top left of splash page (wet-boew/issues/2667) about wet-boew-php

[nschonni]

@nschonni I'm not sure how the azure site works so I'm not sure if it's updated. I checked the demo php splash page on the Sauce Labs and confirmed the PNG image is broken. I'm trying to figure out if it's because the azure site is using an out-of-date wet-boew-dist reference.

@upsonp The the git submodule is still pointing the the 3.1.0 release so it needs to be bumped up. Azure will use whatever commit that the submodule is pointing to.

[upsonp]

Thanks @nschonni

I don't know how to update the sub module, is it something I can do?

[michael-milette]

@upsonp and @nschonni

Sorry, seems that my IE was suffering from caching issues so I switched to a different machine. What I found is that, in the ZIIP file I downloaded earlier today, the splash pages work fine but the server pages don't show the 2 images in the header because they are pointing to:

• /dist/theme-gcwu-fegc/images/sig-eng.png
• /dist/theme-gcwu-fegc/images/wmms.png

Both are white images on a white page background.

Upon inspection of the source code in /dist-php/theme-gcwu-fegc/serv/head-nav.php, I see the unaltered lines for the images:

• $SIG_ALT = $SITE['gcwu_sig' . $_PAGE['lang1']];
• $WMMS_ALT = $SITE['gcwu_wmms' . $_PAGE['lang1'] ];

So it doesn't look like the change made it into the ZIP file.

Let me know if there is anything I can do to help.

[upsonp]

@michael-milette I had changed them, but then swapped them back when nschonni pointed out Laurent's comment

This only applies to the splash page. Be careful to not apply this to other pages or you will have a black logo on a black bar.

I also just tested the server page out with Sauce Labs and didn't see the issue. (Screen cap include)

[michael-milette]

@upsonp

Try using IE8 from Sauce Labs and go to:
http://wet-boew-php.azurewebsites.net/demos-php/theme-gcwu-fegc/sp-pe-eng-fra.php

AZURE ONLINE ----
Splash Pages: Image doesn't work (broken link to image)
Server pages: Images work.

FROM ZIP FILE -----
Splash Pages: Image work.
Server pages: Images don't work (white image on while background)

[upsonp]

@michael-milette Good news, I updated the server images to include the -alt for the fall back images and tested in Sauce Labs. Now both the Splash Page and Server Page are exhibiting the same broken image for me.

To me this says the issue is definitely that the Azure site is not using the updated WET-BOEW-DIST reference. But that being said, the ZIP should now work for both images if you could test that out for me when you have time.

I unfortunately don't have IE 8 on any machine that I could use to test against one of my private servers.

@nschonni you commented in #2667 that the /wet-boew sub module was still pointing to the wet 3.1 release and needed to be bumped up. How do we go about doing that?

[michael-milette]

Hi @upsonp , thank you implementing the fix. The splash and the server pages all display perfectly now in IE8 when using the files from the ZIP file I downloaded moments ago.

[nschonni]

@upsonp I've updated the submodule to point to the 3.1.2 release now. Here are some instructions for the future http://chrisjean.com/2009/04/20/git-submodules-adding-using-removing-and-updating/

[upsonp]

Thanks @nschonni

[michael-milette]

@upsonp , I believe this issue can be closed as it is resolved.