Comments (10)
@nschonni I'm not sure how the azure site works so I'm not sure if it's updated. I checked the demo php splash page on the Sauce Labs and confirmed the PNG image is broken. I'm trying to figure out if it's because the azure site is using an out-of-date wet-boew-dist reference.
@upsonp The the git submodule is still pointing the the 3.1.0 release so it needs to be bumped up. Azure will use whatever commit that the submodule is pointing to.
from wet-boew-php.
Thanks @nschonni
I don't know how to update the sub module, is it something I can do?
from wet-boew-php.
Sorry, seems that my IE was suffering from caching issues so I switched to a different machine. What I found is that, in the ZIIP file I downloaded earlier today, the splash pages work fine but the server pages don't show the 2 images in the header because they are pointing to:
- /dist/theme-gcwu-fegc/images/sig-eng.png
- /dist/theme-gcwu-fegc/images/wmms.png
Both are white images on a white page background.
Upon inspection of the source code in /dist-php/theme-gcwu-fegc/serv/head-nav.php, I see the unaltered lines for the images:
- $SIG_ALT = $SITE['gcwu_sig' . $_PAGE['lang1']];
- $WMMS_ALT = $SITE['gcwu_wmms' . $_PAGE['lang1'] ];
So it doesn't look like the change made it into the ZIP file.
Let me know if there is anything I can do to help.
from wet-boew-php.
@michael-milette I had changed them, but then swapped them back when nschonni pointed out Laurent's comment
This only applies to the splash page. Be careful to not apply this to other pages or you will have a black logo on a black bar.
I also just tested the server page out with Sauce Labs and didn't see the issue. (Screen cap include)
from wet-boew-php.
Try using IE8 from Sauce Labs and go to:
http://wet-boew-php.azurewebsites.net/demos-php/theme-gcwu-fegc/sp-pe-eng-fra.php
AZURE ONLINE ----
Splash Pages: Image doesn't work (broken link to image)
Server pages: Images work.
FROM ZIP FILE -----
Splash Pages: Image work.
Server pages: Images don't work (white image on while background)
from wet-boew-php.
@michael-milette Good news, I updated the server images to include the -alt for the fall back images and tested in Sauce Labs. Now both the Splash Page and Server Page are exhibiting the same broken image for me.
To me this says the issue is definitely that the Azure site is not using the updated WET-BOEW-DIST reference. But that being said, the ZIP should now work for both images if you could test that out for me when you have time.
I unfortunately don't have IE 8 on any machine that I could use to test against one of my private servers.
@nschonni you commented in #2667 that the /wet-boew sub module was still pointing to the wet 3.1 release and needed to be bumped up. How do we go about doing that?
from wet-boew-php.
Hi @upsonp , thank you implementing the fix. The splash and the server pages all display perfectly now in IE8 when using the files from the ZIP file I downloaded moments ago.
from wet-boew-php.
@upsonp I've updated the submodule to point to the 3.1.2 release now. Here are some instructions for the future http://chrisjean.com/2009/04/20/git-submodules-adding-using-removing-and-updating/
from wet-boew-php.
Thanks @nschonni
from wet-boew-php.
@upsonp , I believe this issue can be closed as it is resolved.
from wet-boew-php.
Related Issues (20)
- remove links on footer menu headers HOT 1
- Maintenance Mode... HOT 2
- PHP Menu Generator HOT 18
- Links in header need to be updated HOT 9
- V4 missing error page coding. HOT 10
- V4 Archived page don't show ARCHIVED - in the title HOT 2
- V4 Archived text need to be updated
- Cloning just the DIST-PHP folder instead of the whole project HOT 8
- GOC Template user how do you... HOT 2
- V4 New issue found while validating with WPSS HOT 2
- WET4 changes that need to be take care! HOT 5
- wet-boew-php as bower dependency HOT 9
- wet-boew-php 4.0 HOT 11
- The Secondary Utility Menu Page - side menu doesn't work. HOT 3
- Base theme footer background is the wrong colour HOT 6
- Title is just a slash on language selection splash page of on demos-php HOT 7
- FIP images missing on 404 server pages in demos-php site HOT 6
- WET 4 - Missing support for session login/logout (sign in/sign out) HOT 3
- Please tag v4.0 branch HOT 2
- GCWeb Canada.ca Redesign theme HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wet-boew-php.