OGPL Theme - PHP Variant about wet-boew-php

[upsonp]

Thanks @michael-milette ,

OGPL must be a newer theme, I don't think it was in when I started working on the PHP variant.

We'll have to start a dialog to get you setup for using GIT. I found it quite taxing to figure out at first, but there's a pretty standard way I work with it now. I don't know where you sit and if the way I do things will work for you.

Do you have you're own testing web server setup?

I have several and I frequently swap between them to try and make sure the variant will work regardless of the OS (Linux Mint, Ubuntu, Windows server 2003) or server type (IIS and Apache)

Do you use anything for web development (Aptana Studio, Dreamweaver, etc...)?

Aptana Studio has really good GIT functionality built in, but I use both. Using Dreamweaver I have 'GIT Bash'. Both are good IDEs for web development, I like Dreamweaver more for it's project management and synchronizing abilities, but Aptana Studio is free, it's based off Eclipse (which as a java developer I'm familiar with), and it's nice to have the GIT function built in.

[michael-milette]

Hi @upsonp,

I do have a couple of testing servers, one on-line (on unix) and the other a localhost running XAMPP on Windows. Both are running on Apache.

For development, I typically go back and forth between Dreamweaver and Notepad++, leveraging the features in each.

I have GitHub for Windows as well as the Git GUI which I installed when I was at the Codefest last week. I have forked the PHP Variant project and cloned it locally in GitGUI/GitBash and GitHub. Today I installed TortoiseGit. So far I've had best luck with GitHub for Windows for cloning and Git GUI for sending changes back to GitHub.

I think I've managed to stage, commit, merge and push my change to:
https://github.com/michael-milette/wet-boew-php-1

It seems to have worked because I can see the changes now. Not sure what to do after that.

[upsonp]

@michael-milette Looks good so far. When you're ready to merge your personal git repository into the main PHP Variant you submit a pull request.

From https://github.com/michael-milette/wet-boew-php-1 click the "Pull Request" link right side menu

Click "New Pull Request" (Green button on the top right)

You should end up on a screen that shows all your changes

Notice the section with the symbol

What it's saying is your merging to the "wet-boew-php:master" from your "michael-milette:master" fork

Click the "Click to create a pull request from this comparison" link

You can leave a comment at this point, then click the Green "Send pull request" button in the bottom right

I think at that point I'll be notified that you've submitted a request to have something merged and I'll review the changes and accept or deny them.

Baring any complications if I accept the changes the merge is done.

[michael-milette]

Thank you for the excellent instructions. They worked! I've bookmarked them for future reference.

Here is the link to the Pull request:
#47

Let me know if you don't receive the notification.

Best regards,

Michael

[upsonp]

Thanks @michael-milette Looks good. The language selection seemed to work ok for me and we can add new demos to it as we go along.

[michael-milette]

Hi @upsonp

With regards to the language selection, you may not have noticed that the language switches regardless of whether you click English or French. And as for Spanish, it's never a link.

The WET theme seems to use a similar type language selector. Unfortunately it suffers from the same shortcomings. I guess we both took a similar approach to trying to make it work.

The current language should not be a link but should have the little arrow under it. Only other languages should be links but should not have an arrow under them. I also noticed that ours changes the order of the language depending on which one is active while the HTML version keeps the order for a more consistent user experience.

[nschonni]

@michael-milette congrats on landing your first PR! 👍 👍 👍
The OGPL theme is really just for a specific site https://github.com/ogpl/ogpl.github.io so I don't know if too much work needs to go into getting it to work in the php variant.
@pjackson28 there isn't a wider audience for that theme correct?

[michael-milette]

Hi @nschonni ,

According to http://ogpl.github.io/index-en.html, the Open Government Platform (OGPL), can be downloaded and evaluated by any national Government or state or local entity. I find it interesting that it says "evaluated by" and not "used by". What would be the point if you can't use it?

On a more personal note, I wanted to see how to do it. Before I knew it, I was almost done! While I don't have any personal need for this theme, I thought I would offer it to @upsonp in case he might be interested in including it in the PHP variant and making it available to all.

These are also the target markets of my current client so I thought I would make it available to them and others who might be interested.

On a side note, I am curious - are any of the themes open for customization and use by anyone outside government?

[nschonni]

Really appreciate the help! (channeling @upsonp 😄 )

---

are any of the themes open for customization and use by anyone outside government?

The only themes that have strings attached are the Government Web Usability and Intranet themes, because they use the Canadian Wordmark that is under Crown copyright.
v3.x offered the base as an example for those wanting to build their own theme, but v4 should hopefully be easier. The City of Ottawa site is an example of someone building their own theme on WET.

[upsonp]

@michael-milette I see what you mean with the language changing regardless of which language option is clicked. I'm half tempted to use the "It's a feature" line.

The Spanish link is just there to demonstrate how it would look with multiple languages. I just used the /dist-php/langselect/lang.php as it was provided, but we could modify the language links to point to lang.php?lang=xxx where xxx is the destination language, then add to the lang.php code to use the $_GET['lang'] variable to redirect to the proper page.

It wouldn't be difficult to do, but I didn't see any need to since the Canadian Government only uses French and English... and I barely speak English. 😆

[pjackson28]

The Open Government Platform (OGPL) as a platform can be used by anyone, but I'm not sure who would be using this specific OGPL design. The design is sourced from ogpl.gov.in and is in use on ogpl.github.io. WET and the OGPL theme are the Government of Canada's contribution to OGPL and OGPL as a platform is in use on data.gc.ca (except using the GC Web Usability theme).

[michael-milette]

Thanks @pjackson28 . Of course the design would be changed but basing a site on WET and taking advantage of the whole WET framework could save developers a lot of development time. Looking forward to WET 4.0.

[michael-milette]

Thanks for the kudos @nschonni I really appreciate it. It was only possible thanks to having attended sessions at the WET Codefest last week and with the assistance of @upsonp Have a great weekend.