GithubHelp home page GithubHelp logo

Comments (6)

wez avatar wez commented on May 22, 2024 1

Thanks for the suggestion!

I've pushed a commit that implements this behavior; a build should show up in the artifacts download section of this GH action run when it completes: https://github.com/wez/wezterm/runs/338534011, and it will show up in the nightly build when that next kicks off.

from wezterm.

ImportTaste avatar ImportTaste commented on May 22, 2024

It works great! Thanks so much!

from wezterm.

ImportTaste avatar ImportTaste commented on May 22, 2024

@wez Hm, actually a thought just occurred to me, and I hesitate to ask because it's not really a big deal and this change on its own is all I really needed.

Could it be allowed to load fonts stored in the portable config directory? Again, it's somewhat trivial since I doubt anyone would care if I installed my font of choice to their machine, but it would be convenient. The check could be reserved for when it's loaded from a portable config, and it would make sense for the "portable font" to take precedence since fonts do get updated with more frequency these days.

from wezterm.

wez avatar wez commented on May 22, 2024

@ImportTaste I like that idea too; would you mind opening a separate issue for it? It's a bit more involved to make that change because font loading has a different implementation on each platform and it might need to get done after some other work I'm considering for the font subsystem. That said, the loader on Windows is the easiest to change, so I may be able to squeak that without too much fuss.

from wezterm.

ImportTaste avatar ImportTaste commented on May 22, 2024

@wez Just got home from work, I would've opened an issue but it looks like you already implemented it if I'm reading correctly. Appreciate it! 👍

EDIT: Ah, I need to be more considerate of other platforms. I'll make that issue.

from wezterm.

github-actions avatar github-actions commented on May 22, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

from wezterm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.