Comments (10)
This seems like a "good first bug" for you or @foolip to do in order to make sure I'm not the only one who understands how the build system works :)
from html-build.
I'm happy to change this somehow. Should we just kill it in favor of having a single .htaccess in the root? And merge all the rules into whatwg/html?
from html-build.
I don't think we can do that for the 404. But all the filetype rules should be merged, and then, hmm... We could either:
- Add a .multipage-htaccess that gets copied over, similar to .multipage-404
- Change the setup so that:
- whatwg/html has a multipage directory containing .htaccess and 404.html
- the build script copies .wattsi-output/multipage-html into multipage/, instead of the current setup which assembles .wattsi-output/multipage-html and then moves it to multipage/.
from html-build.
Maybe we can do that for the 404 actually, we just need to learn how to scope .htaccess rules to one subdirectory.
from html-build.
OK, so here's what the generated /mutlipage/.htaccess
looks like:
ErrorDocument 404 /multipage/404.html
<files *.txt>
ForceType text/plain
</files>
<files *.js>
ForceType text/javascript
</files>
<files *.css>
ForceType text/css
</files>
<files *.html>
ForceType text/html
</files>
Comparing that to https://github.com/whatwg/html/blob/master/.htaccess I take it the solution here is to eliminate duplication and move as much as possible to the top-level .htaccess?
As for the 404, can't we use the same 404 for everything?
from html-build.
https://html.spec.whatwg.org/not-here says "Additionally, a 404 Not Found error was encountered while trying to use an ErrorDocument to handle the request." so that's a problem...
from html-build.
If we did the script might need adjustments too. That would make building potentially simpler though since you could just keeping throwing away /multipage/
as is happening now.
from html-build.
As for the 404, can't we use the same 404 for everything?
I don't think so. The multipage 404 is specifically designed to be a redirect, by including fragment-links.js and some multipage-specific text. See whatwg/html#79.
But yes, I agree with moving as much as possible to the top level.
from html-build.
I think the 404 is actually generic enough and you only get the redirect if the URL ends in a fragment that is understood by the script. Not needing either the 404 or the .htaccess
in /multipage/
would reduce some complexity so I think we should just go for that. The only thing we need to change is the URL pointing to the script and the URL pointing to the /multipage/
contents.
I will work on some patches unless I hear otherwise.
from html-build.
Fixed through #18 and whatwg/html#107.
from html-build.
Related Issues (20)
- Update highlighter once it updates widlparser
- Build does not fail on invalid Web IDL HOT 5
- Review Drafts have MDN in them; they should not HOT 2
- --password warning HOT 2
- MDN boxes sometimes have multiple entries for the same browser HOT 3
- Remove caniuse boxes in favor of MDN compat data boxes? HOT 9
- Build failing, potentially Python? HOT 2
- Migrate to Python 3 HOT 2
- Use Docker Hub pdfsizeopt instead of downloading from GitHub
- Document why macOS cannot do HTTP/2 by default HOT 2
- Consider a "fast mode" for local iteration HOT 3
- .pre-process-main.pl can be simplified or rolled into Wattsi HOT 2
- Add service worker support
- html-build repo is missing License text file
- "Improvements to the CI Docker build" broken PDF links HOT 1
- `.cache` folder is not created by `build.sh` HOT 1
- Docker build fails on M1 MacBook HOT 5
- Build failing locally when trying to send to server HOT 1
- Local build doesn't catch HTML parsing errors
- Automatically generate bibliography entries
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from html-build.