GithubHelp home page GithubHelp logo

Comments (6)

matthewp avatar matthewp commented on June 15, 2024

@caridy I think this should be labeled a bug. This problem means loader.install and loader.provide can only be safely used prior to any <module> tags or prior to any module loading having started. I'm not sure what their use-case would be if this were intentional and not a bug.

This same bug existed in the old System.set/System.define form and it made them effectively unusable.

from loader.

caridy avatar caridy commented on June 15, 2024

I will look into the details next week.

from loader.

dherman avatar dherman commented on June 15, 2024

This may have been fixed along the way as @caridy has been cleaning up the pipeline logic. He's currently working on a refactor of how the pipeline is represented (see PR #91). The semantics should be carefully ensuring there's only ever one promise stored for each stage, and we should only ever cancel an earlier stage's promise after a later stage has already been resolved. So I don't see off the top of my head how this bug would come up. But let's revisit it after the PR lands.

from loader.

caridy avatar caridy commented on June 15, 2024

@matthewp this is now fixed (after PR #97).

from loader.

matthewp avatar matthewp commented on June 15, 2024

You meant "now fixed", right?

from loader.

caridy avatar caridy commented on June 15, 2024

jejeje, yes! fixed.

from loader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.