GithubHelp home page GithubHelp logo

Comments (4)

annevk avatar annevk commented on May 22, 2024

What kind of wrapper do you use for the tests? https://github.com/w3c/web-platform-tests/blob/master/url/urltestparser.js normalizes the expected null result for the hostname getter. You might have missed that change?

from url.

Sebmaster avatar Sebmaster commented on May 22, 2024

Woops, sorry, that was my fault too, I was comparing myHostname with yourHost. Comparing both hostnames seems to match.

However, when comparing host, this problem persists. Spec says to also return empty string on null, however urltestparser.js doesn't normalize it the same way.

from url.

annevk avatar annevk commented on May 22, 2024

Yeah, but the test files are not testing the host property. If they need to you're right, but that should just change in the harness then (and represent internal host with a different property). From a specification perspective the internal host can be null, and that's all that's represented here.

from url.

Sebmaster avatar Sebmaster commented on May 22, 2024

Oh, I see. If the internal host prop isn't meant to be tested then that's fine.

Thanks.

from url.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.