Comments (4)
What kind of wrapper do you use for the tests? https://github.com/w3c/web-platform-tests/blob/master/url/urltestparser.js normalizes the expected null result for the hostname getter. You might have missed that change?
from url.
Woops, sorry, that was my fault too, I was comparing myHostname
with yourHost
. Comparing both hostnames seems to match.
However, when comparing host
, this problem persists. Spec says to also return empty string on null, however urltestparser.js
doesn't normalize it the same way.
from url.
Yeah, but the test files are not testing the host property. If they need to you're right, but that should just change in the harness then (and represent internal host with a different property). From a specification perspective the internal host can be null, and that's all that's represented here.
from url.
Oh, I see. If the internal host prop isn't meant to be tested then that's fine.
Thanks.
from url.
Related Issues (20)
- Meta: UTS46 feedback HOT 8
- Be clearer that non-UTF-8 code paths are only relevant for a small subset of implementations
- Allow specifying additional "special" schemes. HOT 3
- Allow `[` and `]` as URL code-points HOT 4
- Proposal: Functional chaining on URLSearchParams HOT 2
- "host-missing" validation error should be a failure
- Broken references in URL Standard HOT 2
- More IDNA roundtrippability issues HOT 3
- IPv4 parser "invents" a valid ip from doi prefix; is this / should this be correct behaviour? HOT 2
- URLSearchParams append/set: variadic values argument? HOT 6
- Let [=UTF-8 percent-encode=] take an extra optional boolean parameter spaceAsPlus (default false) HOT 11
- HISTORY & SECURITY: URL Parsing Differences Between Implementations Security Issues HOT 1
- Consider defining a primitive for a host-and-port parser
- Skipping an item while iterating is undefined HOT 1
- The origin of "blob:" URL containing inner "blob:" URL HOT 1
- invalid-reverse-solidus error definition has character mixed up. HOT 3
- ContextJ (RFC 5892) is Security Theater HOT 2
- Redundant condition in #fragment-state HOT 1
- Proposal for new version of parsing spec HOT 2
- Differentiate from zero-sized fragment and no fragment in url HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from url.