Comments (8)
So per https://matrixlogs.bakkot.com/WHATWG/2021-06-02#L81 —
i just found that if i change -F die-on=warning to F die-on=fatal, it seems to work as expected
…you mean that causes the image to get used as expected?
That seems to suggest the WARNING: Couldn't determine width and height of this image: stroked-text.png
problem is what causes the failure when die-on=warning
is set. And that warning is coming from Bikeshed, so that seems to indicate the image at least got successfully copied to where Bikeshed expects to find it… maybe?
So sounds like some insight from @tabatkins on this might be needed.
from whatwg.org.
…you mean that causes the image to get used as expected?
Actually... no. So that's obviously not a great path forward.
from whatwg.org.
https://tabatkins.github.io/bikeshed/#img-size
Note: Bikeshed will only successfully detect the size of local images, and will not attempt to fetch resources over the network, as there is no way for Bikeshed to know whether the size it would get is stable. Using local images is generally preferred, but if you need to use a remote one, consider setting the width and height manually.
I guess the issue here is the fact that bikeshed doesn't know about these EXTRA_FILES, because they're not actually sent. So it bails.
whatwg.org/resources.whatwg.org/build/deploy.sh
Lines 65 to 81 in dafacf4
from whatwg.org.
from whatwg.org.
It seems like you could fix this by adding width="" and height="" attributes to the source, maybe?
Yeah -- I was just filing an issue to do that as a workaround for the compat spec.
from whatwg.org.
Yeah, it's good practice to add width/height anyway, so Bikeshed started warning when it couldn't auto-determine them for you.
from whatwg.org.
so that seems to indicate the image at least got successfully copied to where Bikeshed expects to find it… maybe?
Nah, the error message makes it clearer that it's not finding the image at all:
WARNING: Couldn't determine width and height of this image: stroked-text.png [Errno 2] No such file or directory: '/tmp/stroked-text.png'
from whatwg.org.
@plinss @tabatkins shouldn't the API-based Bikeshed not try to open such an image or are we expected to include the images in the payload somehow? (If so, how?)
from whatwg.org.
Related Issues (20)
- Too many files for deploy to list them all HOT 3
- convert-policy.py and Markdown HOT 4
- Add tests for convert-policy.py
- website-service-worker.js breaks after redirecting. HOT 3
- Make headers sticky? HOT 4
- Update FAQ for AppCache removal HOT 1
- Review Drafts issue HOT 6
- List Twitter accounts on spec.whatwg.org
- deploy.sh (build resources) fails with unbound variable error
- convert_sg_db.py should alphabetize by standard name
- broken link to multipage HOT 1
- review.sh: make it easier to overwrite a copy
- Tweak color contrast of highlighting
- Consolidate colors
- SW fails to fetch spec CSS on first load of the day HOT 2
- Confusing UI for `<details>` in the Participant Agreement HOT 5
- Sort out hgroup usage HOT 3
- New checker for https://whatwg.org/validator/
- Store specification build outputs in git HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from whatwg.org.