GithubHelp home page GithubHelp logo

Comments (3)

wheaney avatar wheaney commented on June 15, 2024

sideview_display_size isn't intended to go over 1.0, but display_zoom is, so it shouldn't be cropped off the edges. I'll look a little closer into this.

from breezy-desktop.

wheaney avatar wheaney commented on June 15, 2024

This actually isn't surprising, because sideview existed before smooth follow, so when I built that portion of the shader I didn't think you'd ever be able to see beyond the edge.

from breezy-desktop.

wheaney avatar wheaney commented on June 15, 2024

So the problem is this:

  1. The virtual_display plugin and shader (IMUAdjust.fx) have the proper logic to do zoom. I actually enable the virtual_display plugin to do smooth follow since smooth follow is just a virtual display that tracks.
  2. Since the user isn't actually opting to use virtual_display mode (it's technically not enabled), I ignore all other settings that the IMUAdjust shader has support for, including zoom. I called it "passthrough" for this reason, it's just stealing the screen movement logic and nothing else. The ignoring (or, rather, resetting) of configs is explicitly done here.

Properly enabling zoom would build on this in a way I'm not super fond of by allowing the passthrough mode to utilize a setting from follow mode. I'm not fond of it because it's no longer just a passthrough, but instead is becoming more "aware" of the other mode, and they really should be distinct. I think the proper fix would be to pull the relevant virtual_display bits out into re-usable functions for the follow plugin and shader to use. That's a lot of work for just one setting, though... so maybe we should just go the route of adding it to passthrough mode.

from breezy-desktop.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.