Comments (7)
Good catch, thanks. We'd accept a PR that fixes this if anyone is up to it.
from nova-flexible-content.
The problem comes from an overflow: hidden
on nova's fields container. I see two possible fixes:
- Move the dropdown DOM element outside the problematic div and position it absolutely ;
- Show the dropdown below the button if we don't have enough space above.
The first one may be a little bit tricky with Vue.js I think, the second one doesn't solve anything if the Flexible field is the only field in the form.
Other ideas ?
from nova-flexible-content.
Maybe we should not make it absolutely positioned. Let it be in the flow. Might need a different design though? Not sure.
Or just find a way to disable the container's overflow: hidden
without breaking anything.
from nova-flexible-content.
IMO we shouldn't touch Nova's base layout. There's probably a good reason (even if I couldn't find it...) for that particular overflow: hidden
.
What are your arguments against the absolutely positioned dropdown?
from nova-flexible-content.
The argument is that we can not control the container's height, which means we can't prevent our popup from sticking out if it's too tall, if it's absolutely positioned.
I don't like this solution either but it might be the only way to make it work in every scenario.
from nova-flexible-content.
The dropdown has max-h-search overflow-y-auto
, meaning its max height is 392px
. After that, the dropdown has a scrollbar.
We could reduce it to max-height: 140px
and position it absolutely, and it won't stick out. Here's an example:
But the Vue.js problem remains, I have no clue how to render the dropdown outside of the field component without messing with Vue's references. I did some quick searches but all the solutions I found are suggesting to modify the base template, which we can't do from a simple PHP package, unless I missed something important.
from nova-flexible-content.
This issue seems fixed in Nova 2.0.9 (or earlier, didn't notice the change before). The overflow: hidden;
on the parent container has been removed.
from nova-flexible-content.
Related Issues (20)
- Z-index incompatibility with the most recent version of Laravel Nova HOT 11
- Delete layout error <danger-button> HOT 2
- Dependent Fields not working HOT 4
- Call to undefined method preventsAccessingMissingAttributes() HOT 3
- "Add layout" dropdown overflow HOT 1
- Not working with replicate function HOT 4
- Dark mode issues HOT 2
- Float-left class not working HOT 1
- Nested flexible layout width HOT 1
- Flexible Content Layouts Truncated When Insufficient Form Content Present HOT 1
- Compatiblity issue with spatie/laravel-medialibrary ^11.4.2
- Resource Details view fails to load in Nova 4.32.13 and up HOT 19
- Laravel 11 Support
- Button cover by card
- The flexible-search-menu does not work. HOT 1
- Regression: Delete button is broken HOT 4
- Can't update models with any flexible field HOT 7
- Flexible isn't opening on Detail and Edit page with Nova v3.3 and Laravel 10
- Flexible not work with DependOn HOT 2
- Spatie Medialibrary incompatibility
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nova-flexible-content.