Comments (3)
@xward hi! Sorry for the slow response, busy month.
I took a look at your code and there's not much you can do about the incr
call themselves, however you can speed it up a little bit by re-using a static state:
Cachex.execute(@store, fn cache ->
Enum.reduce(checkers, %{}, fn {id, key, period, allowed, decision_if_above}, acc ->
{:ok, n} = Cachex.incr(cache, key)
# new ? set ttl
if n == 1, do: Cachex.expire(cache, key, period)
Map.put(acc, (n > allowed && decision_if_above) || :pass, id)
end)
end)
This will skip an ETS table lookup on each call to your cache, which actually is most of the overhead involved here. If you want to try this out, you should see a fair amount of speed up - it might be enough for your use case.
Let me know! Happy to discuss further if you need further improvements, maybe we can figure out something in the API that might help.
from cachex.
It indeed improved performances, thanks ! ~25% with 500 checkers (cf benchmarks)
I guess there is no way around calling incr/2 for each checkers I have.
from cachex.
@xward there's a potential that something this might also be a little faster.
I haven't been able to test this, not on my work machine - but hopefully you get the idea. Let me know if it helps!
Cachex.execute(@store, fn cache ->
Enum.reduce(checkers, %{}, fn {id, key, period, allowed, decision_if_above}, acc ->
Cachex.get_and_update(cache, key, fn
(nil) -> { :commit, 1, ttl: period }
(val) -> { :commit, val + 1 }
end)
Map.put(acc, (n > allowed && decision_if_above) || :pass, id)
end)
end)
The idea is that it combines it all into one single cache call, rather than multiple - although you still need to call per key.
from cachex.
Related Issues (20)
- fetch executes fallback if cached value is nil HOT 3
- Issue with specific cache key HOT 5
- Set TTL in fallback read-through cache HOT 5
- Only one call to fetch should return :commit
- Restructure around latest tooling and standards
- `Cachex.Spec.expiration` is underspecified in documentation
- What's the default expiration value when using Cachex.put? HOT 1
- Manually trigger cache warmers HOT 4
- Potential memory issues with LRW policy HOT 3
- Transactions not permitting parallel execution HOT 2
- Add a simple eviction policy to enforce limits with low memory overhead
- fetch and expire not setting TTL HOT 29
- Add a very basic LRU cache clear implementation HOT 3
- Does `Cachex.fetch` accept `ttl` option? HOT 4
- Supervisor.start_link/2 HOT 2
- Sending a message to `self()` when starting a warmer crashes app HOT 8
- Using Cachex with Phoenix and iex HOT 4
- [Elixir 1.15] ** (MatchError) no match of right hand side value: {1, {:error, :no_cache}} HOT 3
- Cachex.fetch hangs and breaks my app HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cachex.