Support for AWS ECR public registry about docker-build-with-cache-action

[whoan]

Hi @AntoineAugusti . Yes, I think AWS ECR public registry should be supported. Let me give it a try at the weekend.

Thanks

[AntoineAugusti]

That's fantastic! If you're short on time, tell me. I should be able to write up a PR in January for this.

[whoan]

I took a look at it and it seems like an easy change. My only concern is that I need to find some way to get the AWS region when we use ECR public. In the private one, I was taking the region from the INPUT_REGISTRY variable, but in the public one it's not present anymore: public.ecr.aws

[AntoineAugusti]

The documentation says that the authentication should always be done on us-east-1

When authenticating to a public registry, always authenticate to the us-east-1 Region when using the AWS CLI.

[whoan]

That is great news @AntoineAugusti . Thanks for your quick reply!

[whoan]

I could not finish this feature yet because I am having an issue pulling all tags from public ECR.

This works:

docker pull public.ecr.aws/p6n4p0s0/hello-world:latest

But this doesn't:

docker pull --all-tags  public.ecr.aws/p6n4p0s0/hello-world

I will try to give it another try before 2021!

Partial work was done here: https://github.com/whoan/docker-build-with-cache-action/compare/support-aws-ecr-public

[whoan]

Hey @AntoineAugusti . Could you give v.5.9.0 a try? I added support to AWS ECR Public and it was trickier than expected but acoording to this test it is working now.

Feel free to reopen this issue if you find any issue.

[AntoineAugusti]

@whoan Thanks for implementing this quickly! I'll report it here as soon as I can