GithubHelp home page GithubHelp logo

Comments (3)

timbomckay avatar timbomckay commented on July 20, 2024 1

Ah yes. Meant to do that a while back but never got around to it. We implemented this in our repo and haven't had any issues since. I'll try to get a PR up today or tomorrow.

from inert.

timbomckay avatar timbomckay commented on July 20, 2024

We have a similar scenario where inert is getting pulled in multiple times and sets the mutation observers each time. I played around with this locally to figure out if there's a way to only set the InertManager when it hasn't been set yet and found it behaves properly if I move the instantiation into the prototype condition.

Currently

/** @type {!InertManager} */
  const inertManager = new InertManager(document);

  if (!Element.prototype.hasOwnProperty('inert')) {
    Object.defineProperty(Element.prototype, 'inert', {

Recommendation

if (!Element.prototype.hasOwnProperty('inert')) {
    /** @type {!InertManager} */
    const inertManager = new InertManager(document);

    Object.defineProperty(Element.prototype, 'inert', {

Not sure if this is the proper solution, but it's hurt us a couple of times and think it shouldn't create the mutation observers if they're already being observed.

from inert.

robdodson avatar robdodson commented on July 20, 2024

This sounds similar to #163

@timbomckay would you be interested in sending in a PR for that fix?

from inert.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.