GithubHelp home page GithubHelp logo

Comments (6)

Samwalton9 avatar Samwalton9 commented on September 21, 2024 1

Need your view on these points also.

Just filing a PR would be sufficient, if you're happy to work on it!

from twlight.

Samwalton9 avatar Samwalton9 commented on September 21, 2024

This is a great point - looks like it was added by @jsnshrmn?

from twlight.

jsnshrmn avatar jsnshrmn commented on September 21, 2024

I agree, since ListApplicationsTest doesn't do anything there, and is defined elsewhere where tests are actually run. This looks like a merge error to me. We rewrote many commits many times for rebases while working on the bundle code.

from twlight.

lalit97 avatar lalit97 commented on September 21, 2024

I agree, since ListApplicationsTest doesn't do anything there, and is defined elsewhere where tests are actually run. This looks like a merge error to me. We rewrote many commits many times for rebases while working on the bundle code.

Oh likely to happen when you people are working on big features like bundle :D

I could not found anything helpful related to process of raising issues in the docs. Should I create a task for it on Phabricator? Also can I raise a PR for this issue?

Need your view on these points also.

from twlight.

lalit97 avatar lalit97 commented on September 21, 2024

Just filing a PR would be sufficient, if you're happy to work on it!

filed one, thank you :)

from twlight.

jsnshrmn avatar jsnshrmn commented on September 21, 2024

Closed by #498

from twlight.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.