GithubHelp home page GithubHelp logo

Comments (7)

clauswilke avatar clauswilke commented on July 30, 2024

Yes, this is a good idea. Can you prepare a pull request?

I think the way to go is to stay explicit, i.e., add a function that converts a base R plot into an object that plot_grid() can work with.

from cowplot.

flying-sheep avatar flying-sheep commented on July 30, 2024

so basically you just want me to add my gwrap_plot to the package (maybe rename it) and document it?

what name do you think would be fitting?

from cowplot.

clauswilke avatar clauswilke commented on July 30, 2024

Yes, exactly. And maybe also mention in the plot_grid documentation that this exists.

Your name gwrap_plot sounds good to me. Alternatively, maybe plot_to_gtable?

from cowplot.

flying-sheep avatar flying-sheep commented on July 30, 2024

other alternatives: gtable_from_plot (analogous to your other gtable_* functions) or plot2gtable.

what do you prefer?

from cowplot.

clauswilke avatar clauswilke commented on July 30, 2024

There's already ggplot_to_gtable in draw.R. I think this could go there as well, with a similar name (plot_to_gtable). Also, upon reconsideration, if you want to integrate this functionality into ggplot_to_gtable (so conversion is done automatically) that's fine by me as well.

from cowplot.

flying-sheep avatar flying-sheep commented on July 30, 2024

well, it’s not converting ggplots, so i could either

  • leave two separate functions, or
  • deprecate ggplot_to_gtable and make plot_to_gtable handle both ggplots and normal plots

from cowplot.

clauswilke avatar clauswilke commented on July 30, 2024

I'm fine with either option, but have a weak preference for the latter.

from cowplot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.