GithubHelp home page GithubHelp logo

Comments (7)

willb335 avatar willb335 commented on May 23, 2024

This is an easy fix, perhaps source = "spare-wR"

from chessboardjsx.

csharptest avatar csharptest commented on May 23, 2024

Yeah :/

Again a structure would have been preferable; however, this would be a breaking change. So either adding a third parameter (source, target, piece: "wR") or if that is trouble, then yes I can parse it out.

from chessboardjsx.

willb335 avatar willb335 commented on May 23, 2024

I can look into making this a structure

from chessboardjsx.

willb335 avatar willb335 commented on May 23, 2024

I'm going to hold off on refactoring the position object into a structure. A few important helper functions, fenToObject and objToFen are based on the current { e5: 'wK' } format. I brought these over from chessboard.js and don't want to rewrite them at the moment.

I will refactor into structures where I can, the position object is the one exception

from chessboardjsx.

willb335 avatar willb335 commented on May 23, 2024

@csharptest let me know if this is a fix

5e46859

from chessboardjsx.

csharptest avatar csharptest commented on May 23, 2024

@willb335 Sounds good, as I said I'm unfamiliar with chessboard.js, so if you are working to make things consistent with that I can understand.

from chessboardjsx.

willb335 avatar willb335 commented on May 23, 2024

The following commit restructures onDrop to have a piece property: onDrop({ sourceSquare, targetSquare, piece }).

42c1ddf

from chessboardjsx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.