Comments (18)
@theCapypara This does fix the issue for me, I submitted #1408.
from gvsbuild.
I think that 2nd patch is already in the latest GTK stable.
from gvsbuild.
Could it maybe be that any enabled direct write support, be it for harfbuzz, cairo or pango causes this?
I am pretty sure I had my users test with a version of my fork again which had NEITHER #1325 or #1328 in them... (for GTK 4! I did test the PR with GTK 3 on its own)
I can give that a go...
from gvsbuild.
Disabling direct write again does not fix this issue.
from gvsbuild.
I should also add that I ran the demo app with windbg to see which DLLs are loaded. Only system DLLs and DLLs of the GTK ecosystem are loaded.
from gvsbuild.
I was told people are also experience this under Windows 10, but I can't reproduce it myself on my Windows 10 test machine.
from gvsbuild.
I am also facing the exact same issue on Windows 11, and it seems to happen in Gaphor (which uses gvsbuild) as well: gaphor/gaphor#3352
from gvsbuild.
What type of video card do you have? I am only able to reproduce the icon corruption on newer AMD Ryzen laptop.
from gvsbuild.
On the PC where I can reproduce it I have an AMD Radeon RX 7800 XT, on the two where I can not reproduce this I have Intel integrated graphics 13th Gen and Virtio graphics driver (KVM/QEMU VM)
I'll do a survey with my users to see what graphics cards they have.
from gvsbuild.
Another user with an AMD Ryzen CPU with hybrid graphics using an NVIDIA mobile GPU also experiences this issue, this is their screenshot they shared:
from gvsbuild.
Another user reports they have a NVIDIA GeForce GTX 1650 on a laptop with hybrid graphics.
from gvsbuild.
Ok, to try to isolate what is causing this, let's do an Is / Is-not analysis:
Text and Icon Corruption
Category | IS | IS NOT |
---|---|---|
GPU | Nvidia, AMD | Intel |
Windows Version | 10 and 11 | |
GTK Version | GTK 4.14.4 | GTK 3.24.43 |
Build System | Gvsbuild | MSYS2 |
Is that a good summary, and is there other things we should check?
from gvsbuild.
That seems like a good summary. So far I had no reports of anybody using just Intel graphics to run into the issue.
I actually don't know if this issue happens with MSYS2. Last time I tested it (on the PC where I run into this issue) it didn't, but that's been quite a while ago.
from gvsbuild.
I just tested it with MSYS2. I can not reproduce this issue, the fonts and icons look perfectly fine.
from gvsbuild.
I asked on the MSYS2 Discord server, they pointed me to this patch they have:
https://github.com/msys2/MINGW-packages/blob/365df49c1b798bb1bde02ac9986ae2edfb2c1088/mingw-w64-gtk4/PKGBUILD#L51C5-L52C51
https://github.com/msys2/MINGW-packages/blob/365df49c1b798bb1bde02ac9986ae2edfb2c1088/mingw-w64-gtk4/0001-ngl-icon-drawing-fix.patch
That seems promising! I won't have time to test it today or tomorrow (probably), I could give it a go after that.
The other patch they have supposedly fixes blurry font rendering:
https://gitlab.gnome.org/GNOME/gtk/-/commit/b569470b87d143d30c2388046c9a6450696f19b8.patch
from gvsbuild.
@theCapypara I couldn't reproduce the issue in MSYS2 either. Good find and teamwork with the MSYS2 team, I am building GTK4 now with the patch to test it.
from gvsbuild.
Great! We might also want to pull in the other patch in another PR, it really seems to improve font rendering for small fonts.
from gvsbuild.
Ah. I haven't tested applying it yet, so it's possible, I thought the MSYS2 Adwaita demo had slightly sharper fonts than the gvsbuild one. I guess I could actually compare them later, maybe it was just my imagination.
from gvsbuild.
Related Issues (20)
- GTK App crashes with g_atomic_ref_count_dec: assertion 'old_value > 0' failed HOT 2
- nghttp2 update to version 1.60.0 fails
- Building GTK4 fails HOT 4
- Error while building gtk3 HOT 12
- GTK4 build fails HOT 2
- gobject-introspection fails without setuptools on Python 3.12
- Link to binaries HOT 1
- Include patch to fix pango font rendering HOT 7
- Font rendering issues for GTK4 HOT 2
- adding gtkmm libraries to the next releases HOT 6
- Allow changing meson options for packages
- patch' is not recognized as an internal or external command, operable program or batch file HOT 1
- Perl depends on old versions of Visual C++ Redistributable HOT 1
- build failed on Win11 while building gdk-pixbuf HOT 17
- FAILED: gdk-pixbuf/loaders.cache (2.42.12) Win 10, gvsbuild build gtk4 HOT 1
- Missing packages fontconfig, pangoft2 HOT 3
- release more binaries HOT 1
- Libpanel missing `panel_get_resource`
- Error: gst-plugins-bad build failed. FAILED: sys/nvcodec/gstnvcodec.dll.p/gstnvdecoder.cpp.obj.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gvsbuild.