EqualsToJson has bad performance for big json with common keys occuring often about wiremock

[leeturner]

Hi, many thanks for taking the time to fork the project and add the test. It is very helpful. Would it be possible to let us know if you are upgrading from one version of WireMock to another where you saw the performance issue so we can try and narrow down where the performance regression might be.

You also mentioned zjson in your issue report. Could you give more information on what zjson is

[dongelci]

Hi @leeturner,

thanks for your feedback.

I mean zjsonpatch. This is a library used before switching to jsonunit. Relevant commit is 7ead912, which was reverted in
ef4cf34 and then reused in 28c5e67.

2.27.2 has no issue. Next release after this is 3.0.0 and there is an issue in it

[tomakehurst]

We switched away from zjsonpatch partly because there were comparison bugs we couldn't resolve with it IIRC.

Since we're dependent on JsonUnit now and the performance issue is presumably within its diff code, maybe it would make sense to raise an issue with that project?

Also, generally I wouldn't recommend using equalToJson for large comparisons. matchesJsonPath is usually much more efficient here, particularly since we introduced some per-request caching that's most effective when you use sub-matchers.

[dongelci]

Hi @tomakehurst ,

Sorry for late reply.

I also suspect diff creation. I would open an issue at JsonUnit but needed to discuss other options with you.

We are using recording feature with persistent stubs. We could write a Transformer maybe but I am afraid json is too dynamic to define a concrete attribute to use matchesJsonPath but I will take into consideration.

I will inform, when I open an issue at JsonUnit