GithubHelp home page GithubHelp logo

Comments (10)

barnson avatar barnson commented on July 20, 2024 1

The ICEs can still be suppressed; this is a new error. We're going to downgrade this message to a warning but be aware that Windows Installer doesn't support major version numbers greater than 255 like you'd expect. You'll probably be safe for a few years...

from issues.

barnson avatar barnson commented on July 20, 2024 1

https://www.firegiant.com/blog/2023/5/30/wix-online-meeting-259-highlights/

from issues.

paulvickery avatar paulvickery commented on July 20, 2024 1

Doh - I'm an idiot! For some reason my last reply doesn't show the first line of the wixproj, but it looks like this:
<Project Sdk="WixToolset.Sdk/4.0.0">

Of course I need to change it to 4.0.1!

Sorry...
and thanks!

from issues.

paulvickery avatar paulvickery commented on July 20, 2024

Thanks for that. I look forward to the next release! 😃

I know that Windows Installer doesn't really support this, but I seem to have got away with it for a few years already!

Ideally, I'd like to change to using a 2-digit date, but couldn't think of a way to do that without breaking upgrades. I posted a question earlier on that at https://github.com/orgs/wixtoolset/discussions/7521. If you have any wisdom you can share that would be great...! 😃

You say this is a new error, and not an ICE, so am I right in thinking that these types of errors cannot be suppressed?

from issues.

robmen avatar robmen commented on July 20, 2024

For the gory details, I recommend watching the meeting video that comes out in 3-4 hours. FireGiant blog will summarize (and link to the video) then too.

from issues.

paulvickery avatar paulvickery commented on July 20, 2024

Fab, thanks. I'll get some popcorn ready! 😆

from issues.

paulvickery avatar paulvickery commented on July 20, 2024

Hi guys,

Many thanks for including this in 4.0.1.

I have updated all nugets and the dotnet tool (globally and in the solution's config) to 4.0.1 but still get it showing as an error. Is there something I need to do to see it now as a warning?

Thanks,

Paul.

from issues.

barnson avatar barnson commented on July 20, 2024

What's the exact message?

from issues.

paulvickery avatar paulvickery commented on July 20, 2024

Exactly the same as I first reported:

error WIX0242: Invalid product version '2024.3.8557.23820'. MSI product versions must have a major version less than 256, a minor version less than 256, and a build version less than 65536. The revision value is ignored but version labels and metadata are not allowed.

Things which may be relevant:

  • I'm using VS2022, with the HeatWave for VS2022 extension, version 1.0.1.
  • I have installed wix 4.0.1 globally, and also have it my solution's .config\dotnet-tools.json
  • My wixproj references WixToolset.Heat, WixToolset.Util.wixext and WixToolset.UI.wixext, all at version 4.0.1.
  • I'm building using the VS2022 build.

My wixproj looks like this:

	<PropertyGroup>
		<EnableProjectHarvesting>false</EnableProjectHarvesting>
		<HarvestDirectoryTransforms>OutputFilter.xslt</HarvestDirectoryTransforms>
		<HarvestDirectorySuppressFragments>true</HarvestDirectorySuppressFragments>
		<HarvestDirectoryAutogenerateGuids>true</HarvestDirectoryAutogenerateGuids>
		<!--<CompilerAdditionalOptions>-sice 24</CompilerAdditionalOptions>-->
	</PropertyGroup>
	<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|x86' ">
		<DefineConstants>Debug</DefineConstants>
		<SuppressPdbOutput>False</SuppressPdbOutput>
		<SuppressSpecificWarnings>1113;0242;242</SuppressSpecificWarnings>
		<SuppressValidation>false</SuppressValidation>
		<SuppressIces>ICE24</SuppressIces>
		<SuppressAllWarnings>true</SuppressAllWarnings>
	</PropertyGroup>
	<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|x86' ">
		<SuppressPdbOutput>True</SuppressPdbOutput>
		<SuppressSpecificWarnings>1113</SuppressSpecificWarnings>
	</PropertyGroup>
	<ItemGroup>
		<ProjectReference Include="..\MyProject\MyProject.csproj" />
	</ItemGroup>
	<ItemGroup>
		<HarvestDirectory Include="..\MyProject\bin\$(Configuration)\net6.0-windows">
			<DirectoryRefId>INSTALLFOLDER</DirectoryRefId>
			<ComponentGroupName>Output</ComponentGroupName>
			<SupressCOM>true</SupressCOM>
			<SuppressRegistry>true</SuppressRegistry>
			<SuppressRootDirectory>true</SuppressRootDirectory>
			<Transforms>OutputFilter.xslt</Transforms>
		</HarvestDirectory>
	</ItemGroup>
	<ItemGroup>
		<Content Include="Licence.rtf" />
		<Content Include="OutputFilter.xslt" />
	</ItemGroup>
	<ItemGroup>
		<PackageReference Include="WixToolset.Heat" Version="4.0.1" />
		<PackageReference Include="WixToolset.Util.wixext" Version="4.0.1" />
		<PackageReference Include="WixToolset.UI.wixext" Version="4.0.1" />
	</ItemGroup>
</Project>

from issues.

barnson avatar barnson commented on July 20, 2024

That means you're still using v4.0.0. WIX0242 doesn't exist in v4.0.1. HeatWave doesn't use the .NET tool version of WiX, so you have to update Project/@Sdk or global.json.

from issues.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.