FirewallException (v5) Profile regression about issues

[dorssel]

Ah, I see, so it can be either, including text. Yes, then formatted makes sense.
(Do note that the "Integer" in the Direction field should still probably be <null>, though).

Thanks for clarifying and fixing!

[dorssel]

Edited: I originally thought it was about the Description property, but it turns out it is the Profile column that produces the error.

[dorssel]

Investigated:

It's the _Validation table that is wrong.

Currently it lists:

Wix5FirewallException	Profile	Y	1	2147483647			Formatted		Profile (1=domain; 2=private; 4=public; 2147483647=all).

It should not be Category=Formatted, but Category=null (see https://learn.microsoft.com/en-us/windows/win32/msi/-validation-table)

There is another definition wrong:

Wix5FirewallException	Direction	N	1	2			Integer		Direction (1=in; 2=out)

That does not give an error, but Category is never "Integer", it should be null instead.

[barnson]

It's a formatted (string) field (to support setting the profile at install time) but was limited to four characters.

[dorssel]

@barnson
If I'm not mistaken, the field in the Wix5FirewallException table is actually an integer (flags). And ICE03 validates it according to the _Validation table. In WiX it is a text, but it gets translated to integer flags. I still think the _Validation table is wrong. Maybe there was also something wrong with the WiX text field. I don't know, since I only used "all". But in the final Wix5FirewallException table it is definitely a number...

[barnson]

It's formatted so you can author Profile="[PROFILE]" and have the type of profile specified at install time via the PROFILE property. If you use one the enum values, it'll get a number (but still be a string field): https://github.com/wixtoolset/wix/blob/develop/src/ext/Firewall/wixext/FirewallConstants.cs