GithubHelp home page GithubHelp logo

Adding Span and Memory about csparse.net HOT 4 CLOSED

wo80 avatar wo80 commented on August 20, 2024
Adding Span and Memory

from csparse.net.

Comments (4)

wo80 avatar wo80 commented on August 20, 2024 1

Hello! Thank you sincerely for providing a nice sparse matrix library.

Hello @delicioustuna , thanks for your kind words!

Adding Span support to the Solve methods shouldn't be difficult. Would you like to go ahead and create a pull request?

from csparse.net.

delicioustuna avatar delicioustuna commented on August 20, 2024 1

Thank you for your prompt response.
I have created a pull request.

#42

I need to add a reference to System.Memory.dll, is this an acceptable change?

from csparse.net.

delicioustuna avatar delicioustuna commented on August 20, 2024 1

Thank you for your reply and for pointing out the additional dependency.

I too would prefer a format with zero dependencies whenever possible, and since there was no better alternative for Span than to refer to Sytem.Memory.dll, this is the way to do it. I hope this will not be a problem for other users.

I will make the changes you suggested. Please wait a moment.

from csparse.net.

wo80 avatar wo80 commented on August 20, 2024

I need to add a reference to System.Memory.dll, is this an acceptable change?

Yes, that's ok for now. Though I like a "zero dependencies" approach, this is much cleaner than having #if NETCOREAPP2_1_OR_GREATER all across the code. I might change that later on, in case I get any complaints.

But please add the dependency only where necessary, so

<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' ">
  <PackageReference Include="System.Memory" Version="4.5.5" />
</ItemGroup>

from csparse.net.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.