GithubHelp home page GithubHelp logo

Comments (10)

Wohlstand avatar Wohlstand commented on July 20, 2024

🤔
2020-11-28_23-50-57.mp4.zip

from opn2bankeditor.

freq-mod avatar freq-mod commented on July 20, 2024

It's only bank 16 that does that, look:
ice_video_20201128-220621_edit_0.zip

from opn2bankeditor.

Wohlstand avatar Wohlstand commented on July 20, 2024

Didn't reproduced at me... maybe I should try this at my Win8.1 computer?

from opn2bankeditor.

Wohlstand avatar Wohlstand commented on July 20, 2024

BLAK MAGIK!!!
2020-11-29_00-17-23.mp4.zip

It reproduced on Windows build ran on Wine!

from opn2bankeditor.

Wohlstand avatar Wohlstand commented on July 20, 2024

Okay, that damn happens on Windows, because the list of banks gets be cleaned-up:

void BankEditor::reloadBanks()
{
    ui->bank_no->clear();
    int countOfBanks = 1;
    bool isDrum = isDrumsMode();
    if(isDrum)
        countOfBanks = ((m_bank.countDrums() - 1) / 128) + 1;
    else
        countOfBanks = ((m_bank.countMelodic() - 1) / 128) + 1;
    for(int i = 0; i < countOfBanks; i++)
    {
        ui->bank_no->addItem(QString(), i);
        refreshBankName(i);
    }
}

because the instrument names reloading call do calling the "setMelodic()" call that calls "reloadBanks()"

🤔

from opn2bankeditor.

Wohlstand avatar Wohlstand commented on July 20, 2024

And I know why: QListWidget item search by wildcard sux: I found a different way to iterate items inside of it, gonna to try...

from opn2bankeditor.

Wohlstand avatar Wohlstand commented on July 20, 2024

@freq-mod , just now I made a fix, please verify the work! 🦊

from opn2bankeditor.

Wohlstand avatar Wohlstand commented on July 20, 2024

// I feel, I need to apply the same fix to OPL3-BE too...

from opn2bankeditor.

Wohlstand avatar Wohlstand commented on July 20, 2024

Done at OPL3-BE too.

from opn2bankeditor.

freq-mod avatar freq-mod commented on July 20, 2024

Looks like that bug is gone, thanks!

from opn2bankeditor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.