ref doesn't reference about react-date-picker

[abaksha-sc]

But firstInputRef sounds really handy!

It's better and easier just to provide prop like firstInputId to make possible to associate the label with the first input.

<label for="date-picker">Date:</label>
<DatePicker firstInputId="date-picker" />

It will be similar to prop inputId of popular "react-select".

But I was also looking for some ref prop to add tabIndex="-1" to the button with calendar icon to prevent focus when user navigates on form with keyboard. So some global ref will be useful for me to execute ref.querySelector(button)

[frederickf]

I'm a little confused. What does "ref is a bad idea for a name here" mean? What name? And if think using ref is a bad idea, then what would firstInputRef be? I'm fine with whatever you prefer, I'm just trying to understand what you're proposing.

UPDATE
I reread your comment and I think I understand now. You're saying to use a new property named firstInputRef that takes a ref that is assigned to the first input. EX

const inputRef = useRef()

<DatePicker firstInputRef={inputRef} />

Is that right?

[wojtekmaj]

Ref was never documented and (even sudden) lack of it can't be considered a bug. What is your use case? Focusing input?

[frederickf]

Thanks for the quick response. We create a label for the date picker, and when a user clicks on the label we were using ref to focus on the first input.

I also have a new use I was intending to use it for, which is exposing some details about an invalid change. For example, getting the field that is invalid and it's current invalid value so I can provide a more detailed error message to the user.

I'd be happy to do a PR for those if you think they are valid use cases. Either by adding support for ref, or something different.

[wojtekmaj]

ref is a bad idea for a name here; it should either be a reference to component itself, or to a root (and usually the only, because it's for a simple cases like Button component) element rendered by this component.

But firstInputRef sounds really handy!

[wojtekmaj]

Yep that's right! Sorry if I failed to explain it clearly.

[frederickf]

I've opened a PR based on our discussion #625

[github-actions]

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this issue will be closed in 14 days.