Timeout not working with SHARED flag about portalocker

[wolph]

I've done a bunch of debugging (I should have kept on reading, would have saved me time :P ) and fail_when_locked is not set in this case. And I don't think it should be.

The main issue is that when you're setting custom flags that you override the default so NON_BLOCKING isn't set either. I believe it is mostly a documentation issue because there are valid reasons to have a blocking lock without a timeout.

So... I think the best solution would be to add a warning if an explicit timeout is set when NON_BLOCKING is not set. That way you at least know what to expect :)

[wolph]

I've released version 2.5.0 which should fix the issues :)

[daviddavo]

It seems like fcntl.flock is what's causing the issue. It hangs in here, but it doesn't even let me pause the debugger.

https://github.com/WoLpH/portalocker/blob/b47d5f485f7c2e4d5af46307c6b3c4d2ea50e5f6/portalocker/portalocker.py#L138

[daviddavo]

Solution: I had to pass the NON_BLOCKING flag as well. Maybe it should be automtically added (or raise a warning) if fail_when_locked is True