GithubHelp home page GithubHelp logo

Comments (5)

nefeline avatar nefeline commented on June 2, 2024

Hi there @vijuarez , thanks for reaching out to us!

I'm not able to reproduce this issue over here, when running npm run build the minified js files are added as expected:

Screenshot 2023-07-23 at 09 45 02

Did you run both composer install and npm install before triggering npm run build ?

from storefront.

vijuarez avatar vijuarez commented on June 2, 2024

Hi @nefeline, thank you for looking into this!

I double checked my environment, and both packages from composer and npm are installed. Some ideas:

  1. Can you try deleting the minified files, and then building? They should reappear on build, if I understand the script correctly.
  2. Could you figure out where npm_package_assets_js_src is defined?

Thanks.

from storefront.

roykho avatar roykho commented on June 2, 2024

Hi @vijuarez - before running npm run build, try running nvm use, npm install and then npm run build. In case you don't have nvm. Here is more information on that https://github.com/nvm-sh/nvm

from storefront.

vijuarez avatar vijuarez commented on June 2, 2024

Hi @roykho, you are right! Switching to Node v14.21.1 solved the issue.

from storefront.

clb92 avatar clb92 commented on June 2, 2024

I'm still having this issue, even with Node v14.21.1. I use NVM (nvm use in the storefront directory) when building, and it does indeed spot the .nvmrc and use the correct version of Node, yet minified files are not generated for me. I have tried with a handful of different NPM versions as well.

Between each build attempt I clear my working directory completely, clean NPM cache, and clone the theme repository again.

The NodeJS ecosystem is a mess.

And the only reason I need to build my own theme in the first place is that I want to change the breakpoints (see #991).

from storefront.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.