Comments (5)
Hi there @vijuarez , thanks for reaching out to us!
I'm not able to reproduce this issue over here, when running npm run build
the minified js files are added as expected:
Did you run both composer install
and npm install
before triggering npm run build
?
from storefront.
Hi @nefeline, thank you for looking into this!
I double checked my environment, and both packages from composer
and npm
are installed. Some ideas:
- Can you try deleting the minified files, and then building? They should reappear on build, if I understand the script correctly.
- Could you figure out where
npm_package_assets_js_src
is defined?
Thanks.
from storefront.
Hi @vijuarez - before running npm run build
, try running nvm use
, npm install
and then npm run build
. In case you don't have nvm
. Here is more information on that https://github.com/nvm-sh/nvm
from storefront.
Hi @roykho, you are right! Switching to Node v14.21.1 solved the issue.
from storefront.
I'm still having this issue, even with Node v14.21.1. I use NVM (nvm use
in the storefront directory) when building, and it does indeed spot the .nvmrc
and use the correct version of Node, yet minified files are not generated for me. I have tried with a handful of different NPM versions as well.
Between each build attempt I clear my working directory completely, clean NPM cache, and clone the theme repository again.
The NodeJS ecosystem is a mess.
And the only reason I need to build my own theme in the first place is that I want to change the breakpoints (see #991).
from storefront.
Related Issues (20)
- Single Product Page > Maybe Hide Quantity Selector HOT 1
- Site Info on Footer appear double HOT 8
- My first project for a woocommerce store
- Various console errors caused by sidebar widgets HOT 1
- The "Storefront header cart" doesn't work properly on the cart and checkout pages HOT 3
- Storefront 4.4.0: Mobile Menu not working HOT 1
- Storefront: Number of items beside cart icon won't update when product quantity is changed on cart page HOT 4
- Header menu cart does not update when product is removed from cart in the cart page. HOT 6
- #2113 breaks refreshing the cart on non-WC cached pages HOT 4
- Hand-picked Products: On Sale Bade - wrong position
- A deprecated notice appears on the admin and front end with WP 6.3 HOT 1
- Remove max-width on image div for Mix and Match Products extension
- Fractional product quantity shown as 0 HOT 1
- Incorrect breakpoint padding/margin-right on Gutenberg
- Error implementing elementor checkout widget in storefront
- Measurement price calculator duplicate fields HOT 1
- Icon of new notices are not visible for certain actions HOT 3
- Incorrect link in readme.md HOT 1
- storefront Mini Cart count and wc is not updating properly HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from storefront.