Return a Response object for all the middlewares. about harmony

[kocsismate]

That would be awesome indeed if Harmony could work well with third party middlewares! So thank you really much for the report as the current mechanism wasn't intentional. :)

Could you tell me other details about your setup? Did you use any official Harmony middleware along with the CORS one? If so, I do hope the only problem is that Harmony's middlewares don't return a response (as you said in the title of the issue).

[kocsismate]

I just pushed the fixes to the master branch! Could you ensure if it works for you?

[superbull]

hi @kocsismate , after this modification, everything works. Below is my setup:

$app
    ->addMiddleware('cors', $corsMiddleware)
    ->addMiddleware("fast_route", new FastRouteMiddleware($router))
    ->addMiddleware("dispatcher", new DispatcherMiddleware($container))
    ->addFinalMiddleware("responder", new DiactorosResponderMiddleware(new SapiEmitter()));

Actually I am also working with your yin-middlewares, I think there are also some modifications needed. For example, in JsonApiDispatcherMiddleware.php an ErrorDocument is returned directly from the middleware:

// JsonApiDispatcherMiddleware.php

...
if ($callable === null) {
    return $this->getDispatchErrorDocument($this->getDispatchError())->getResponse($response);
}
...

[kocsismate]

Good job with the PR, I'll release Harmony 2.3 shortly with this fix! Your comment on Yin-middlewares is also valid, I'll address it soon.

[kocsismate]

I've done with the release: Harmony will trigger a deprecated notice if a middleware returns with a Response.

[superbull]

good news!