Site Editor: Add a screen for adding or uploading a site logo / favicon about gutenberg

[annezazu]

This is a duplicate IMO of #50860. Going to close this out as a result and let's continue the discussion there. @andrewserong please add your thoughts as a comment!

[bgardner]

Would this complement the new UI on the General Settings page?

https://twitter.com/bgardner/status/1761077710426710038

[tomxygen]

Would this complement the new UI on the General Settings page?

I think so.
As more things are placed in the site editor, I don't see why not adding the favicon as well.
The new UI in General Settings works fine, especially for those who are not using a block theme yet.

Also, what do you think about using the favicon/logo to replace the WP logo in wp-login?

[andrewserong]

Thanks folks, I hadn't seen that!

Would this complement the new UI on the General Settings page?

I'd think so — the main idea behind this issue is that it'd be good for folks not to have to leave the site editor in order to make changes.

[andrewserong]

Just linking the trac ticket for the site icon in the general settings page: https://core.trac.wordpress.org/ticket/54370

[hanneslsm]

I couldn't find an existing issue for this exactly, so if there is one, let me know and I'll close this out as a duplicate!

I think the previous discussion would be this #50860 but it didn't go into details and solutions.

@jameskoster made a note for "global settings", which I like better than "Site identity". ("Site identity" and "Styles" would be too close)