GithubHelp home page GithubHelp logo

Comments (4)

t-hamano avatar t-hamano commented on June 26, 2024

Thank you for your suggestion.

The new 'Add' button should show when first inserting the empty block and always shown at the end when the block is selected and being edited:

The two inserter buttons for inserting blocks feel a little strange to me since they have the same role.

The approach I suggest is to automatically insert one Social Link block when you insert a Social Links block:

image

The only block that can be included in a Social Links block is a Social Link block, and its initial behavior is the same as that of a Buttons block:

image

And if no Social Icon block exists, it will only show the default inserter:

image

This is also similar to the current Buttons block behavior:

image

Are there any accessibility concerns with this approach? Whichever direction we go in, I feel it's better to unify the behavior of the social icon block and the button block.

from gutenberg.

t-hamano avatar t-hamano commented on June 26, 2024

As another example, the specifications for the navigation block are as follows:

When a block is not selected: A dot border is displayed.

image

When a block is selected: A large inserter button is displayed.

image

from gutenberg.

richtabor avatar richtabor commented on June 26, 2024

I think this is along what I was suggesting previously, by always having an icon inserter to the right of the icons, when interacting with the block.

#56259 (comment)

from gutenberg.

afercia avatar afercia commented on June 26, 2024

The two inserter buttons for inserting blocks feel a little strange

I agree. I'm unsure whether the black 'plus' ineerter should be kept. It is worth noting that right now it is not operable with a keyboard after a first social link has been added. See #60120
This block is not operable with a keyboard. As such, either we fix the inserter or we should replace it.

from gutenberg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.