GithubHelp home page GithubHelp logo

Comments (13)

talldan avatar talldan commented on June 8, 2024 4

IMO, the change takes things in the right direction. It makes more sense to add the tags in the code editor view, since that's where html is generally added, and it's now also possible to view the result of the html tags in visual mode.

As @t-hamano mentioned, it's perhaps an issue that there's no way to add formatting visually and some users may have the code editor disabled. Perhaps we keep this issue open to discuss that aspect?

I've removed the bug label since it works as intended currently.

from gutenberg.

t-hamano avatar t-hamano commented on June 8, 2024 3

I have confirmed that this change was intentional and was made by #54718.

The main purpose seems to be to match the look of the title in the editor and the frontend. It's also mentioned that we can't add or edit HTML in visual mode, so perhaps the ideal approach would be to implement a formatting toolbar in the title.

from gutenberg.

dansinker avatar dansinker commented on June 8, 2024 3

Yeah, keeping this open for discussion on adding a formatting toolbar to the post title is great.

So you understand the use-case here:

Proper formatting of titles (books, albums, movies, etc) is to italicize them. The publication I work for has covered culture for 50 years, and regularly italicizes titles in their headlines (happened 3-4 times the day after the 6.5 update and nobody knew what was happening). Asking our editors to fire up the code editor to do something that should be part of normal editorial workflow seems like a lot, not to mention that inevitibly they will break something in the process.

from gutenberg.

MadtownLems avatar MadtownLems commented on June 8, 2024 2

+1 to the idea of the Post Title box having a basic toolbar for formatting, such as Italics. Our users don't have the ability to access Code Editor, but still need to be able to use italics (for things like the scientific name of plants). Thanks @talldan so much for the suggestion of using Quick Edit as a workaround for now!

from gutenberg.

dansinker avatar dansinker commented on June 8, 2024 1

Possibly this was changed at some point, but I'm not exactly sure of the history.

This was not the case prior to 6.5's rollout this week. Has disrupted our editorial workflow significantly.

from gutenberg.

t-hamano avatar t-hamano commented on June 8, 2024 1

It might be better to keep this issue open as an "Enhancement" that adds a formatting toolbar to the post title when in visual mode.

from gutenberg.

talldan avatar talldan commented on June 8, 2024 1

Asking our editors to fire up the code editor to do something that should be part of normal editorial workflow seems like a lot, not to mention that inevitibly they will break something in the process.

@dansinker Another option is to use 'Quick Edit' from the post list to add the formatting, not sure if that's any easier.

from gutenberg.

talldan avatar talldan commented on June 8, 2024

Previously, it was possible to add HTML tags in the visual editor.

@akmyta I think HTML tags have to be added via the code editor and not the visual editor. Possibly this was changed at some point, but I'm not exactly sure of the history.

I've tested, and adding tags is possible if you do it via the code editor. Via the visual editor the tags are escaped.

from gutenberg.

akmyta avatar akmyta commented on June 8, 2024

@talldan If I complete the same steps in WordPress version 6.4.3 - it works as expected.

htmltags.mp4

from gutenberg.

t-hamano avatar t-hamano commented on June 8, 2024

I researched this issue via Playground and it works as expected from WP6.1 to WP6.4. In WP6.5, HTML tags are escaped. I don't yet know if this is an intentional change.

from gutenberg.

dansinker avatar dansinker commented on June 8, 2024

@talldan yes, that's what we've instructed them to do, but it's still a slower process than what they had before. ultimately it really does seem like if the idea is that the visual editor should allow for visual editing only, then adding visual editing to the title is the correct solution.

from gutenberg.

HeinMynn avatar HeinMynn commented on June 8, 2024

+1 for the formatting toolbar for the Post Title.

from gutenberg.

dlh01 avatar dlh01 commented on June 8, 2024

I've observed since updating to 6.5 that the & character is converted to & in the post title as soon as it's typed, regardless of the user's role or capabilities. The encoded character then gets saved to the database.

Having & converted by KSES on save for users without the necessary capabilities has been a longstanding problem (see #20490), but this seems different.

I'm not positive that this change in behavior is caused by the same change being discussed here, so feel free to direct my comment to a better place if there is one.

from gutenberg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.