GithubHelp home page GithubHelp logo

Comments (7)

annezazu avatar annezazu commented on June 30, 2024 1

With that said, I've updated the name and labeling of this issue a bit to see what we can do to address the issue around the white text and being unable to see the background!

from gutenberg.

gabbsmo avatar gabbsmo commented on June 30, 2024 1

It looks like you include the background group in your pattern so that will naturally work. Try only selecting the paragraphs of text inside the group and create the pattern from that. Then you should get what I described in the OP.

I don't have a recording right now but can make it later if you need it.

from gutenberg.

talldan avatar talldan commented on June 30, 2024 1

If this is needed for "partially synced patterns" then do it for "partially synced patterns" not for "synced patterns".

@ktmn The challenge here is that it will be possible to use both partially synced patterns and synced patterns in the same post, so having inconsistent editing of those patterns would be a confusing experience.

The change did also fix this bug - Editing a Synced Pattern that you don't have permission to edit is a poor user experience.

from gutenberg.

ktmn avatar ktmn commented on June 30, 2024

lost the ability to edit synced patterns inline on a post where it is used

I agree, this change was a regression in my opinion.

I tracked down where it changed and appears to be here: #57036

As part of the work on allowing partial editing of synced patterns we want to disable full editing of the synced pattern entities within the block editor.


Needs Design Feedback

Gutenberg = it's like a Word document, you click on the text and you can change it. Simple! Now when you click on a pattern nothing happens. The text is not editable. That's the end of the road for most people. Roll it back.

If this is needed for "partially synced patterns" then do it for "partially synced patterns" not for "synced patterns".

from gutenberg.

annezazu avatar annezazu commented on June 30, 2024

Thanks for opening this issue. To build on what was shared above, this change was done to accommodate an upcoming feature that allows you to have a synced pattern with the option to allow for specific parts of it to be overridden within individual patterns. This means you could have part of a design and text set across all synced patterns along with some customization to make specific instances of the same pattern your own. As a result, the new experience was introduced. It's a trade off for sure but it won't be rolled back as is.

from gutenberg.

gabbsmo avatar gabbsmo commented on June 30, 2024

My spontaneous suggestion is to introduce a toggleable dark mode to Gutenberg/WP Dashboard.

from gutenberg.

richtabor avatar richtabor commented on June 30, 2024

This is what I'm getting. Do you mind sharing a screen recording (and/or do you notice a variable)?

CleanShot.2024-04-23.at.17.06.42.mp4

from gutenberg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.