Comments (3)
For a new, more meaningful, aria-label for the link preview it's worth reminding the link preview can show a few things that are conceptually different.
The fetched information of an external site displayed in a 'rich data' preview, including the site icon:
Same for an internal link.
Or, if the link destination page can't be fetched, it will display a generic icon, the link text, and the link url with the protocol part stripped out:
Or, when the link text is the same as the link url, it may show only the link:
Given this UI can show different things, sometimes it may actually not be a 'preview'. A new, more meaningul, labeling should likely avoid the term 'preview' and use a more generic terminology to commuincate users this is generic information about the destination page.
from gutenberg.
Note: translatable should avoid concatenation. In the case illustrated below, the colon :
is not translatable.
The WordPress l10n guidelines recomment to always use fully translatable strings, including punctuation.
gutenberg/packages/block-editor/src/components/link-control/link-preview.js
Lines 146 to 150 in e33cb88
from gutenberg.
Additionally: when the preference 'Show button text labels' is enabled, all three buttons still show the tooltips, they just repeat the visible text. That's redundant and should be avoided as it's done for other buttons in the UI.
Screenshot:
from gutenberg.
Related Issues (20)
- JavaScript Documentation: Improve the JS API documentation tool. HOT 5
- Inserter: Pattern tab visibility HOT 3
- Block Editor: `BlockCanvas` component is exposed on both public/private
- Only engage zoom out mode if the editor is focused on an entity HOT 3
- should viewScriptModule still be experimental in the scripts package?
- Proposal: Keep the Inserter open HOT 24
- Typo - build/edit-site/index.js:23718 HOT 2
- typo - build/editor/index.js HOT 1
- Double border applied when "Page" tab is active
- LinkControl: Add CSS class to improve styling for external links HOT 3
- Padding visualizer shows stale padding when block opts to handle application of style HOT 1
- DropdownMenuItemV2: Add "destructive" state HOT 1
- Create Pattern Modal: Modal disappears when focus is moved with tab key HOT 3
- Follow up questions on the duplicate post and page feature HOT 2
- DataViews: Extensibility HOT 4
- Tricky issue with the Gutenberg Button Block Alignment and Justification option select style
- Getting Started > Fundamentals of Block Development: Clarify requirements to add editor styles for a block
- Zoom-out can trigger double scrollbars in the editor canvas. HOT 2
- Migrate DropdownMenu instances to DropdownMenu V2 HOT 1
- Components: Document our deprecation procedures HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gutenberg.