Comments (10)
I tried replicating with 6.6-beta2-58426 using WordPress nightly on Playground and couldn't. Going to add it to the 6.6 board to be safe but curious if others can replicate.
from gutenberg.
Thanks for testing and putting it on the board. I’m not sure it will be reproducible on Playground as I tested and did’t see any Welcome Guide ever. I thought that was supposed to act like a fresh install so that’s puzzling to me. If no Welcome Guides are shown perhaps we can’t expect the apparition either.
I’m still seeing it on trunk though I've realized there’s another requirement to reproduce. When clicking the "edit" button of a page, the preview has to be showing the initial "home" page. I.e. the page you are about to edit shouldn’t be highlighted/selected. This quite obscure so probably not much of a priority.
from gutenberg.
I attempted to recreate this bug against 7201eec and with WP 6.6 beta 3 (WP Beta Tester plugin), but I'm not certain I'm following the reproducible steps?
I tested in Chrome 126 with cache disabled and Network throttling for Slow 3G and Fast 3G while clicking through various site editor screens and I was not able to reproduce it.
I’m still seeing it on trunk though I've realized there’s another requirement to reproduce. When clicking the "edit" button of a page, the preview has to be showing the initial "home" page. I.e. the page you are about to edit shouldn’t be highlighted/selected. This quite obscure so probably not much of a priority.
Do you mind providing updated testing steps to recreate the issue please? I'm also wondering if this is impacted by define( 'SCRIPT_DEBUG', true );
?
from gutenberg.
Thanks for testing.
Do you mind providing updated testing steps to recreate the issue please?
I don’t mind but I’m not able to see any missing step. I revised them a bit to hopefully make it more clear. If it helps here’s another repro video (this one from 5738e9b):
welcome-guide-apparition-2.mp4
I'm also wondering if this is impacted by
define( 'SCRIPT_DEBUG', true );
?
Good query. I checked again and can reproduce either way.
from gutenberg.
I also tried, but can't reproduce this 🤔
from gutenberg.
Back here to report that I was able to reproduce this while testing in Playground. I had to visit in a private window to have any Welcome Guides showing up and had to visit the editor once to dismiss the expected ones. After that, exiting to the dashboard and following the reproduction steps worked. Though, I do think sometimes it’s not visible probably due to painting performance variations in the browser.
Screen.Recording.2024-07-15.at.10.06.49.AM.mp4
Also the reason I tested Playground again was I happened to notice elsewhere @annezazu had reproduced this on Playground #61489 (comment), it can be see in that video 11 seconds into it.
from gutenberg.
Hi,
This issue has gone 30 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.
from gutenberg.
Just saying this still happens.
from gutenberg.
I can reproduce - I think it's important that there are no user preferences stored in the browser (the preference key is welcomeGuideTemplate
), hence the private window test scenario mentioned above.
I had to screenshot a frame of my screencast as the optimized video reduced the frame rate 😄
As far as I can tell, the template welcome guide will show when the store subscription callback thinks that the current page is a page type and the current post type is a template, among other conditions:
gutenberg/packages/edit-site/src/components/welcome-guide/template.js
Lines 29 to 34 in 8c4be58
Here's what I'm logging from the selector when I follow the test instructions:
{isTemplateActive: true, isEditorActive: false, isPage: false, currentPostType: 'wp_template'}
{isTemplateActive: true, isEditorActive: false, isPage: true, currentPostType: 'wp_template'} // Flash here - it satisfies the conditions
{isTemplateActive: true, isEditorActive: false, isPage: true, currentPostType: 'page'}
from gutenberg.
Ramon, thanks for testing and inspecting this. I looked into this further and it appears that the flash of the template welcome guide is only half the issue. The other half is that it never presents as originally implemented in #52014. From what I see there, it should appear when one has chosen to edit a template starting from editing a page. I can’t get that to happen on trunk or testing WP 6.6 on Playground. The latter surprised me because #52014 was apparently backported to 6.6 and should have been working.
I’ve spun up #64789 aimed to resolve this.
from gutenberg.
Related Issues (20)
- Buttons block: block spacing value does not apply to both vertical and horizontal alignment HOT 4
- Site Editor: Selecting different fonts in Styles causes Editor to crash in certain themes HOT 3
- Bug Report: Popover Modals Display Incorrectly in Visual Block Editor When Metaboxes Are Present HOT 1
- Embed blocks: figcaption inserted via toolbar not nested within figure element HOT 2
- Tabs: Keyboard navigation and indicator issues in RTL languages HOT 3
- Is there any way to reorder core components block editor control in the right panel HOT 2
- Fix focus style of social icons with no link yet HOT 4
- If you set a global link font size in the FSE editor and styles you can't overwrite it with blocks HOT 1
- Query Loop: Make Display panel accessible when Query Type = default
- Give Template-Part Block a filter to influence template part query result - Replace actions with filters?
- Search block: setting option to button only causes UI inconsistency in displaying search field HOT 1
- Backdrop-filter as Background Option
- Data Store: invalidateResolution not working HOT 13
- Inserter browse all shows non-allowed blocks in InnerBlocks HOT 8
- Allow extending editor preview in more ways HOT 4
- [wp-env] Allow to set WP_HOME and WP_SITEURL through environment variables HOT 1
- Data Views: show trashed templates and patterns
- DataViews: stress testing `primaryField`, `mediaField`, and `view.fields` HOT 7
- Zoom out: some lag when both patterns and browse Style open in Safari HOT 2
- Zoom out: missing animation when moving patterns in Firefox HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gutenberg.