GithubHelp home page GithubHelp logo

Comments (9)

bgardner avatar bgardner commented on August 22, 2024 3

Heh, I could make the argument that it is a bug, but that would only be wishful thinking.

In short, I understand and agree with what you said.

from gutenberg.

aaronrobertshaw avatar aaronrobertshaw commented on August 22, 2024 2

and likely easier to ship with RC2?

I think this might be seen more as an enhancement rather than a bug fix, so I don't think it will make it into any of the 6.6 RCs.

from gutenberg.

aaronrobertshaw avatar aaronrobertshaw commented on August 22, 2024 2

A draft PR is up for removing the block style previews from the inspector panel only: #63039.

I am having some problems with my local native env at the moment so I've left the PR in a draft state until I can sort that out and see whether it still makes sense to remove the previews there too.

from gutenberg.

bgardner avatar bgardner commented on August 22, 2024

+1 for improving (or removing) previews for section styles.

from gutenberg.

aaronrobertshaw avatar aaronrobertshaw commented on August 22, 2024

Just flagging that there were a couple of earlier explorations into updating the UI for Block Styles:

While these were focused on the control itself, e.g. dropdown vs small cards etc., it did come up that the preview isn't really required as it was so easy to see it in action or switch back to the default.

I can put together a quick PR to remove the preview and see what people think.

from gutenberg.

bgardner avatar bgardner commented on August 22, 2024

I can put together a quick PR to remove the preview and see what people think.

TBH, I think this is better (and likely easier to ship with RC2?) to remove than to style a preview.

from gutenberg.

aaronrobertshaw avatar aaronrobertshaw commented on August 22, 2024

The block styles still use an inline preview for the native UI. Given the next iteration of section styles/block style variations will likely involve a major update to this panel, I wonder if it makes sense to hold off on updating the native UI.

I've suggested over on #63039 that this could be a separate follow-up but happy to hear other's thoughts on this one.

from gutenberg.

annezazu avatar annezazu commented on August 22, 2024

Thanks for the quick work here.

from gutenberg.

aaronrobertshaw avatar aaronrobertshaw commented on August 22, 2024

The removal of previews appears to be overkill. An alternate approach, simply improving the Group block's example, is available in #63114.

from gutenberg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.