GithubHelp home page GithubHelp logo

Comments (8)

carolinan avatar carolinan commented on August 30, 2024

The design with only the search form and no results will not be used, removing the decision needed label.

from twentytwentyone.

luminuu avatar luminuu commented on August 30, 2024

Updated my inital post.

from twentytwentyone.

melchoyce avatar melchoyce commented on August 30, 2024

Right now the theme does not feature any search icon in the header or footer areas, so we're not sure from where the first design should be reached.

You can reach the results pages by using a search block or widget.

from twentytwentyone.

luminuu avatar luminuu commented on August 30, 2024

Yup! That sentence referred to the initial search results page with just the search input itself, which we don't have anymore. I've striked it through.

from twentytwentyone.

melchoyce avatar melchoyce commented on August 30, 2024

Ahh cool, okay πŸ‘

from twentytwentyone.

carolinan avatar carolinan commented on August 30, 2024

I believe these two pages are completed and that this can be closed?

from twentytwentyone.

luminuu avatar luminuu commented on August 30, 2024

Bildschirmfoto am 2020-10-02 um 21 15 21

So I've been just testing the mobile version of the search results screen, I think we do not want to have the search results headline break like this?

The code which causes this can be found here: https://github.com/WordPress/twentytwentyone/blob/trunk/assets/sass/06-components/archives.scss#L3

All other headlines on blog posts and regular pages look normal, it seems only the archive-pages have the break-word property.

from twentytwentyone.

melchoyce avatar melchoyce commented on August 30, 2024

Good catch, let's get rid of that property.

from twentytwentyone.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.