Read_IT instructions need reviewed about stream-adventure

[ccarruitero]

Hi @BenjDG

Thanks for the feedback. The read_it exercise it's a bit new (was introduced around 2 months ago).

I'll try to take a look into how to improve explanation in the sections that you mention, but PR are always welcome :) .

You can found solutions for this exercise in the repository, in the problem's folder and in the problem's test

[gkatsanos]

This exercise has some issues:
Implement a Readable stream, initiate a new stream instance from your
implementation and pipe to process.stdout. You will receive the content to
add to your stream like first argument.

The last sentence seems auto-translated. Should be : "the input for your stream is given from the 2nd process argument, process.argv[2]."
In addition, you need to state that the values are separated by newline or comma (or both) and mention something about "size".

To be honest I would remove this exercise for now until its a bit more stable.

[BenjDG]

Hey @ccarruitero
Thanks for the response, I was enjoying the 'adventure' until that point and then had to skip it.
I'm new to JavaScript with Nodejs, but have a background in teaching and the instructions just seemed a little confusing.
Thanks for addressing my comments, I really like the format of the 'adventure' from easy to hard.
Keep up the good work!

[ccarruitero]

Hi @gkatsanos

The first argument that you pass throw command line arguments is parsed as process.argv[2] in Node.js.

I'm open to reword the argument sentence, or any other, you are free to open a PR :).

I think the solution was left from an initial implementation that was a bit more complex that how ended up the exercise. To solve the exercise you don't really need to implement the _read method, just need to have one (_read method) in your stream implementation, push the content to your stream and then pipe your stream to stdout.

The solution in tests is enough to solve the exercise

I'll cleanup the reference solution to avoid confusion.