GithubHelp home page GithubHelp logo

Comments (3)

schlessera avatar schlessera commented on June 15, 2024

I assume it is more important to have that included in the JsCodeExtractor.php file. The code seems to be exactly the same, though:

/** @var DirectoryIterator $file */
if ( in_array( $file->getBasename(), $exclude, true ) ) {
return false;
}
// Check for more complex paths, e.g. /some/sub/folder.
foreach( $exclude as $path_or_file ) {
if ( false !== mb_ereg( preg_quote( '/' . $path_or_file ) . '$', $file->getPathname() ) ) {
return false;
}
}

This makes me wonder again about where to DRY up the code...

from i18n-command.

swissspidy avatar swissspidy commented on June 15, 2024

This makes me wonder again about where to DRY up the code...

#54 could solve this.

from i18n-command.

swissspidy avatar swissspidy commented on June 15, 2024

For reference, this is how the current makepot.php script does it:

https://github.com/WordPress/wordpress-develop/blob/4ce3db3e8d25099bb9f1f017b7006d3fc2dfaa3c/tools/i18n/extract.php#L48-L67

from i18n-command.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.