GithubHelp home page GithubHelp logo

Comments (5)

bradamiller avatar bradamiller commented on September 25, 2024

With 5.0.8 RobotBuilder generates code that doesn't work because the TalonSRX class doesn't implement SpeedController. So in my case I have a robot with 4 motor drive and RobotBuilder creates a DifferentialDrive with two SpeedController groups (left and right side). The SpeedControllerGroup needs SpeedControllers as the arguments, same as DifferentialDrive if I only had 2 motors. Is there a way of just getting TalonSRX and VictorSPX to directly implement SpeedController?

from robotbuilder.

sciencewhiz avatar sciencewhiz commented on September 25, 2024

Is there a disadvantage to always calling getWPILIB_SpeedController() in Robot Builder generated code?

from robotbuilder.

bradamiller avatar bradamiller commented on September 25, 2024

Probably not, it just seems cleaner and less confusing for teams that aren't privy to this discussion. I was curious why it didn't just implement the class instead of returning the proxy class. But I just tried the suggested RobotBuilder change and it seems to work except for a few typos in the posted solution.

from robotbuilder.

sciencewhiz avatar sciencewhiz commented on September 25, 2024

Is this OBE with the latest changes in Phoenix?

from robotbuilder.

ozrien avatar ozrien commented on September 25, 2024

Since Phoenix now has compatible classes WPI_TalonSRX/WPI_VictorSPX, this is no longer an issue.

from robotbuilder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.